From: Pavel Machek <pavel@ucw.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: malattia@linux.it, kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
trivial@kernel.org
Subject: Re: struct should not be named same way as function in sony-laptop
Date: Thu, 3 Jan 2008 18:09:30 +0100 [thread overview]
Message-ID: <20080103170930.GA1728@elf.ucw.cz> (raw)
In-Reply-To: <20080103111543.GS27894@ZenIV.linux.org.uk>
On Thu 2008-01-03 11:15:43, Al Viro wrote:
> On Thu, Jan 03, 2008 at 12:01:54PM +0100, Pavel Machek wrote:
> > Naming struct and function by same name is evil. Rename the struct.
>
> Um... why? It's not even particulary bad style per se... Occurs less
> frequently than things like
> struct foo *foo;
> but nothing inherently terrible and not likely to cause any kind of
> confusion.
Well, it confused me a lot in this particular case...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2008-01-03 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 11:01 struct should not be named same way as function in sony-laptop Pavel Machek
2008-01-03 11:15 ` Al Viro
2008-01-03 17:09 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080103170930.GA1728@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=malattia@linux.it \
--cc=trivial@kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.