Re: codiff misses changes if inline -> not inlined?

[Arnaldo Carvalho de Melo <acme-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>]

Em Fri, Jan 04, 2008 at 12:41:40AM +0200, Ilpo Järvinen escreveu:
> On Thu, 3 Jan 2008, Arnaldo Carvalho de Melo wrote:
> 
> > Em Thu, Jan 03, 2008 at 06:45:32PM +0200, Ilpo Järvinen escreveu:
> > > On Thu, 3 Jan 2008, Arnaldo Carvalho de Melo wrote:
> > > 
> > > Now that I automated it for inlines per file, one thing that annoys me a 
> > > bit is that it does not keep identical formatting on the last line (it's 
> > > fixable of course by some simple sed trickery):
> > > 
> > > static inline int tcp_may_raise_cwnd(const struct sock *sk, const int 
> > > flag)
> > > net/ipv4/tcp_input.c:
> > >   tcp_prune_queue |  -16
> > >  1 function changed, 16 bytes removed
> > > 
> > > ...versus...
> > > 
> > > static inline int tcp_may_update_window(const struct tcp_sock *tp,
> > > net/ipv4/tcp_input.c:
> > >   tcp_disordered_ack |  -18
> > >   tcp_ack            |  -76
> > >  2 functions changed, 94 bytes removed
> > > 
> > > net/ipv4/tcp_input.c:
> > >   tcp_may_update_window |  +56
> > >  1 function changed, 56 bytes added
> > > 
> > > net/ipv4/tcp_input.o:
> > >  3 functions changed, 56 bytes added, 94 bytes removed, diff: -38
> > > 
> > > 
> > > diff: xx is not always present.
> > 
> > Fixed, please do a git-pull.
> 
> ...much better with piped sort now (only added lines seemed to show up 
> still without diff and they're not that interesting after all :-)), but
> I think this is needed as well to complete the change...

Will check that, thanks for reporting! :-)

- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe dwarves" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html