All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] /* inside comment in libfdt.h
Date: Fri, 4 Jan 2008 10:41:25 +1100	[thread overview]
Message-ID: <20080103234125.GC12883@localhost.localdomain> (raw)
In-Reply-To: <477D3BBF.9020301@ge.com>

On Thu, Jan 03, 2008 at 02:47:11PM -0500, Jerry Van Baren wrote:
> Jon Loeliger wrote:
>> On Wed, 2008-01-02 at 07:13, Jerry Van Baren wrote:
>> Oh man....
>> OK.  For the record, I'm all for only comments like this:
>>     /*
>>      *
>>      */
>> Clearly lax, I'll start enforcing it on the DTC sources more.
>> Sorry.
>> jdl
>
> FWIIW, the misdeed was the sample code embedded inside the comment had a 
> (sample) commented line "// add code here" which was done with a C++ // 
> comment so that it didn't run afoul of the C compiler's no nested comments 
> rule.  A certain dignitary who breaks out in a rash when he sees // 
> comments made a "trivial" change to a /* */ comment, which then caused the 
> C compiler to throw a hissy fit because it now *was* a nested comment.
>
> All in all, a comedy of good intentions.  No Code Was Harmed(R) in the 
> making of this patch sequence.

Oh dear.  Yes, I believe those '//' were deliberate to avoid nested
comments.  Think of them as pseudo-code, not C++ if that makes it any
more palatable.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2008-01-03 23:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-02 12:46 [U-Boot-Users] /* inside comment in libfdt.h Matthias Fuchs
2008-01-02 13:13 ` Jerry Van Baren
2008-01-02 13:49   ` Matthias Fuchs
2008-01-03 19:28   ` Jon Loeliger
2008-01-03 19:35     ` Scott Wood
2008-01-03 19:47     ` Jerry Van Baren
2008-01-03 23:41       ` David Gibson [this message]
2008-01-04 10:24     ` Matthias Fuchs
2008-01-04 12:43       ` Jerry Van Baren
2008-01-04 16:22       ` Jon Loeliger
2008-01-02 15:01 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080103234125.GC12883@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.