From: Joel Becker <Joel.Becker@oracle.com>
To: git@vger.kernel.org
Subject: wherefore art thou, git-applymbox? - Adding non-self signoffs
Date: Thu, 3 Jan 2008 17:50:28 -0800 [thread overview]
Message-ID: <20080104015028.GC3989@mail.oracle.com> (raw)
Junio, et al,
When git-applymbox disappeared, I didn't pay much attention. I
just learned git-am and went along. Little did I know, there was a
trap laid.
The ocfs2-tools.git repository is maintained by the entire ocfs2
team. It's a "shared" style repo. A proposed change is posted to
ocfs2-tools-devel, and when a teammate approves, they respond with a
signoff. The author then adds the signoff to the patch and pushes to
the shared repo.
We used to do this very easily with git-applymbox:
(from http://oss.oracle.com/osswiki/GitRepositories/ForMaintainers)
$ echo "Julie Hacker <julieh@my.site.com>" > /tmp/signoff
$ git branch to-push master
$ git checkout to-push
$ git format-patch -C -k --stdout master..workingbranch > /tmp/changes-to-push
$ git applymbox -k /tmp/changes-to-push /tmp/signoff
$ git push ssh://my.server.com/path/project.git to-push:master
The <signoff> file argument to applymbox allowed us to add the
approvers signoff to an entire series in one go. git-am does not have
this feature. As far as I can tell, I have to edit each patch by hand
to add the new signoff. Is there a better way?
Joel
--
Life's Little Instruction Book #356
"Be there when people need you."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next reply other threads:[~2008-01-04 1:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 1:50 Joel Becker [this message]
2008-01-04 3:32 ` wherefore art thou, git-applymbox? - Adding non-self signoffs Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104015028.GC3989@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.