From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759341AbYADJBS (ORCPT ); Fri, 4 Jan 2008 04:01:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757916AbYADJBE (ORCPT ); Fri, 4 Jan 2008 04:01:04 -0500 Received: from mx3.mail.elte.hu ([157.181.1.138]:60648 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754699AbYADJBD (ORCPT ); Fri, 4 Jan 2008 04:01:03 -0500 Date: Fri, 4 Jan 2008 10:00:52 +0100 From: Ingo Molnar To: Andi Kleen Cc: peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH x86] [5/16] Replace hard coded reservations in x86-64 early boot code with dynamic table Message-ID: <20080104090052.GE28740@elte.hu> References: <20080103442.621670000@suse.de> <20080103154218.F294E14DDB@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103154218.F294E14DDB@wotan.suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > On x86-64 there are several memory allocations before bootmem. To > avoid them stomping on each other they used to be all hard coded in > bad_area(). Replace this with an array that is filled as needed. > > This cleans up the code considerably and allows to expand its use. this code introduces a number of style errors that make the code harder to read and follow. Please fix them. Ingo