From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758224AbYADJEH (ORCPT ); Fri, 4 Jan 2008 04:04:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753793AbYADJDu (ORCPT ); Fri, 4 Jan 2008 04:03:50 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:41203 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753510AbYADJDs (ORCPT ); Fri, 4 Jan 2008 04:03:48 -0500 Date: Fri, 4 Jan 2008 10:03:38 +0100 From: Ingo Molnar To: Andi Kleen Cc: peterz@infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH x86] [7/16] Convert lockdep to use arch_early_alloc() if available for its large arrays Message-ID: <20080104090338.GF28740@elte.hu> References: <20080103442.621670000@suse.de> <20080103154221.1CC8C14DDB@wotan.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103154221.1CC8C14DDB@wotan.suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Andi Kleen wrote: > +#ifndef ARCH_HAS_EARLY_ALLOC > +#define LARGEVAR(x,y) { static typeof(*x) __ ## x[y]; x = __ ## x; } > +#else > +#define LARGEVAR(x,y) x = arch_early_alloc(sizeof(*x) * y) > +#endif your patch makes sense in principle, but please do this via the Kconfig space - we dont introduce new ARCH_HAS flags anymore and try to get rid of the existing ones as well. Ingo