From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, olof@lixom.net
Subject: Re: [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON()
Date: Fri, 4 Jan 2008 11:43:22 +0100 [thread overview]
Message-ID: <20080104104322.GA18199@elte.hu> (raw)
In-Reply-To: <477E0CAB.2040402@linux.intel.com>
* Arjan van de Ven <arjan@linux.intel.com> wrote:
> Ingo Molnar wrote:
>> * Arjan van de Ven <arjan@linux.intel.com> wrote:
>>
>>> + printk(KERN_WARNING "------------[ cut here ]------------\n");
>>> printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>>> line, function);
>>> + print_modules();
>>> dump_stack();
>>> + print_oops_end_marker();
>>
>> another thing: could we also put the marker into dump_stack(), and attach
>> the marker to the Call Trace line?
>
> I have a preliminary patch for that already but I'm not happy with it
> yet; I need to redo it properly. It's neither depending nor
> incremental to these 2 patches though..
yeah, it was a sidenote - it should be separate to these two patches.
Ingo
next prev parent reply other threads:[~2008-01-04 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 21:27 [patch 2/2] Add the end-of-trace marker and the module list to WARN_ON() Arjan van de Ven
2008-01-04 7:45 ` Ingo Molnar
2008-01-04 10:38 ` Arjan van de Ven
2008-01-04 10:43 ` Ingo Molnar [this message]
2008-01-04 10:48 ` Heiko Carstens
2008-01-04 14:50 ` Arjan van de Ven
2008-01-04 17:19 ` Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104104322.GA18199@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.