From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAl8E-0005eY-Tz for mharc-grub-devel@gnu.org; Fri, 04 Jan 2008 06:54:34 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAl8C-0005aR-DM for grub-devel@gnu.org; Fri, 04 Jan 2008 06:54:32 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAl8B-0005YN-7t for grub-devel@gnu.org; Fri, 04 Jan 2008 06:54:32 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAl8B-0005YC-2j for grub-devel@gnu.org; Fri, 04 Jan 2008 06:54:31 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAl8A-0006r0-Us for grub-devel@gnu.org; Fri, 04 Jan 2008 06:54:31 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAl5w-0000Uv-6Y for grub-devel@gnu.org; Fri, 04 Jan 2008 12:52:12 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAl3c-0007UZ-UV for grub-devel@gnu.org; Fri, 04 Jan 2008 12:49:48 +0100 Date: Fri, 4 Jan 2008 12:49:48 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080104114948.GB3020@thorin> References: <471E4628.9030706@t-online.de> <20071118112737.GB16674@thorin> <474202DA.4010001@t-online.de> <47790D50.4060000@t-online.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47790D50.4060000@t-online.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Fix eisa_mmap evaluation, add memory existence check X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 11:54:32 -0000 Committed. On Mon, Dec 31, 2007 at 04:40:00PM +0100, Christian Franke wrote: > This version of the patch contains only the fix for the E801 EISA memory > map. The memory existence check was helpful for testing but is not > really necessary. > > But this bug should be fixed, otherwise GRUB2 would crash if BIOS does > not provide the E820 memory map. > > Christian > > > 2007-12-31 Christian Franke > > * kern/i386/pc/init.c (grub_machine_init): Fix > evaluation of eisa_mmap. > > > --- grub2.orig/kern/i386/pc/init.c 2007-10-22 22:22:51.359375000 +0200 > +++ grub2/kern/i386/pc/init.c 2007-12-31 16:05:59.953125000 +0100 > @@ -199,13 +199,8 @@ grub_machine_init (void) > > if (eisa_mmap) > { > - if ((eisa_mmap & 0xFFFF) == 0x3C00) > - add_mem_region (0x100000, (eisa_mmap << 16) + 0x100000 * 15); > - else > - { > - add_mem_region (0x100000, (eisa_mmap & 0xFFFF) << 10); > - add_mem_region (0x1000000, eisa_mmap << 16); > - } > + add_mem_region (0x100000, (eisa_mmap & 0xFFFF) << 10); > + add_mem_region (0x1000000, eisa_mmap & ~0xFFFF); > } > else > add_mem_region (0x100000, grub_get_memsize (1) << 10); > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)