From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Markus Hitter <mah@jump-ing.de>, Robert Reif <reif@earthlink.net>
Subject: Re: [Qemu-devel] [PATCH] fix possible NULL pointer use in hw/ptimer.c
Date: Fri, 4 Jan 2008 17:44:05 +0000 [thread overview]
Message-ID: <200801041744.05953.paul@codesourcery.com> (raw)
In-Reply-To: <99DF1970-75E9-4D9D-A6D3-C0F71B2CC6C5@jump-ing.de>
On Friday 04 January 2008, Markus Hitter wrote:
> Am 03.01.2008 um 15:02 schrieb Paul Brook:
> > Having to check every return value is extremely tedious and (as
> > you've proved) easy to miss.
>
> Checking every return value is a measure for programming reliable code.
Never failing is even more reliable.
> > If the allocation fails we don't have any viable alternatives, so
> > we may as well stop right there.
>
> Stop != segfault?
Yes.
> What about a meaningful exit message?
"Out of memory" is a fairly comprehensive description of the problem.
In fact I'd say it's much more informative than "<random widget the user
doesn't know or care about> failed to initialize".
Paul
next prev parent reply other threads:[~2008-01-04 17:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-03 2:29 [Qemu-devel] [PATCH] fix possible NULL pointer use in hw/ptimer.c Robert Reif
2008-01-03 2:43 ` Paul Brook
2008-01-03 2:57 ` Robert Reif
2008-01-03 14:02 ` Paul Brook
2008-01-04 17:29 ` Markus Hitter
2008-01-04 17:44 ` Paul Brook [this message]
2008-01-04 18:14 ` Robert Reif
2008-01-05 0:44 ` Rob Landley
2008-01-05 1:07 ` Paul Brook
2008-01-05 2:47 ` Rob Landley
2008-01-05 9:55 ` Markus Hitter
2008-01-06 12:14 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801041744.05953.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=mah@jump-ing.de \
--cc=qemu-devel@nongnu.org \
--cc=reif@earthlink.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.