From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JAtLV-0006VM-HD for mharc-grub-devel@gnu.org; Fri, 04 Jan 2008 15:40:49 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JAtLT-0006VD-Gm for grub-devel@gnu.org; Fri, 04 Jan 2008 15:40:47 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JAtLR-0006Uv-3X for grub-devel@gnu.org; Fri, 04 Jan 2008 15:40:46 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JAtLQ-0006Uq-VJ for grub-devel@gnu.org; Fri, 04 Jan 2008 15:40:45 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JAtLR-00021a-1p for grub-devel@gnu.org; Fri, 04 Jan 2008 15:40:45 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JAtLO-0001ai-Je for grub-devel@gnu.org; Fri, 04 Jan 2008 21:40:43 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JAtJz-0003Es-31 for grub-devel@gnu.org; Fri, 04 Jan 2008 21:39:15 +0100 Date: Fri, 4 Jan 2008 21:39:15 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080104203915.GB9375@thorin> References: <20071016210907.GA10870@thorin> <87ir29342i.wl@dekkers.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ir29342i.wl@dekkers.cx> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] split realmode and loader routines out of startup.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 20:40:48 -0000 On Fri, Jan 04, 2008 at 06:15:17PM +0100, Jeroen Dekkers wrote: > At Tue, 16 Oct 2007 23:09:07 +0200, > Robert Millan wrote: > > This patch splits realmode and loader routines out of startup.S. The idea > > is that the LinuxBIOS port can be adapted to share more code with the rest > > of GRUB instead of duplicating it. > > > > This is quite critical stuff, so even if the change seems trivial I'd suggest > > being careful, since I don't trust myself too much. Of course, I've tested > > that it can still boot Linux and Multiboot (on qemu only). Perhaps testing > > on real hardware would be appropiate (but I don't have this handy atm). > > > * kern/i386/pc/startup.S (protstack): Moved to ... > > * kern/i386/realmode.S (protstack): ... here. > > * kern/i386/pc/startup.S (gdt): Moved to ... > > * kern/i386/realmode.S (gdt): ... here. > > * kern/i386/pc/startup.S (prot_to_real): Moved to ... > > * kern/i386/realmode.S (prot_to_real): ... here. > > > > * kern/i386/pc/startup.S: Include `kern/i386/loader.S' and > > `kern/i386/realmode.S'. > > Why did you move prot_to_real to realmode.S, but not real_to_prot? > That seems a bit strange to me... Because on i386-pc, GRUB wants to do both things, but on i386-linuxbios, you start in protected mode and only want to switch once to real mode when booting Linux. There's no way back AFAICT. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)