From: "J. Bruce Fields" <bfields@fieldses.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [RFC] Remove BKL from fs/locks.c
Date: Fri, 4 Jan 2008 18:41:56 -0500 [thread overview]
Message-ID: <20080104234156.GH14827@fieldses.org> (raw)
In-Reply-To: <20071230061615.GS11638@parisc-linux.org>
On Sat, Dec 29, 2007 at 11:16:15PM -0700, Matthew Wilcox wrote:
>
> I've been promising to do this for about seven years now.
>
> It seems to work well enough, but I haven't run any serious stress
> tests on it. This implementation uses one spinlock to protect both lock
> lists and all the i_flock chains. It doesn't seem worth splitting up
> the locking any further.
I think you missed the code in lockd and nfsd4 code that walks the
i_flock lists, and you might want to grep for i_flock to make sure
that's all.
In fact, lockd runs entirely under the bkl, so it may take a careful
review to make sure there aren't some other odd places where it depends
on that for mutual exclusion with code in locks.c.
Yipes. Thanks for working on this.
--b.
prev parent reply other threads:[~2008-01-04 23:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-30 6:16 [RFC] Remove BKL from fs/locks.c Matthew Wilcox
2007-12-30 9:36 ` Stephen Rothwell
2007-12-30 14:42 ` Matthew Wilcox
2007-12-31 0:47 ` Stephen Rothwell
2007-12-30 13:05 ` Christoph Hellwig
2007-12-30 14:51 ` Matthew Wilcox
2007-12-30 15:17 ` Andi Kleen
2007-12-30 18:44 ` Trond Myklebust
2007-12-30 19:18 ` Andi Kleen
2007-12-30 19:23 ` Trond Myklebust
2008-01-04 23:41 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080104234156.GH14827@fieldses.org \
--to=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.