All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlo Marcelo Arenas Belon <carenas@sajinet.com.pe>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support
Date: Fri, 4 Jan 2008 20:06:47 -0600	[thread overview]
Message-ID: <20080105020647.GB20718@tapir> (raw)
In-Reply-To: <20080105010230.GA2230@miranda.arrow>

On Sat, Jan 05, 2008 at 01:02:30AM +0000, Stuart Brady wrote:
> On Fri, Jan 04, 2008 at 06:25:25PM -0600, Rob Landley wrote:
> > On Friday 04 January 2008 04:02:07 Carlo Marcelo Arenas Belon wrote:
> > 
> > > > -            buf[7] = total_sectors <= 1433600 ? 0x08 : 0x10; /* current
> > > > profile */
> > 
> > Where does the constant come from, anyway?
> 
> 1433600?  Seems it's the number of 512 KiB blocks in a 700 MiB CD image 
> (700 * 1024 * 2).

yes, that magic constant corresponds to the maximum expected size for a CD-ROM
and is used to detect if the profile used should be for DVD-ROM or not.

It came from the original implementation patch for "GET CONFIGURATION" 
committed in revision 1.66 of ide.c by Filip Navarra as 
"Partial IDE DVD emulation"

http://cvs.savannah.nongnu.org/viewvc/qemu/hw/ide.c?root=qemu&r1=1.65&r2=1.66

Carlo

  parent reply	other threads:[~2008-01-05  1:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-26  7:36 [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support Carlo Marcelo Arenas Belon
2008-01-04 10:02 ` Carlo Marcelo Arenas Belon
2008-01-05  0:25   ` Rob Landley
2008-01-05  1:02     ` Stuart Brady
2008-01-05  1:57       ` Stuart Brady
2008-01-05  2:06       ` Carlo Marcelo Arenas Belon [this message]
2008-01-05  3:53       ` Rob Landley
2008-01-05 10:28         ` Stuart Brady
2008-01-06  2:22           ` Carlo Marcelo Arenas Belon
2008-01-06 13:57             ` Stuart Brady
2008-01-06 14:32               ` Andreas Färber
2008-01-07  0:38                 ` Carlo Marcelo Arenas Belon
2008-01-07  0:23               ` Carlo Marcelo Arenas Belon
2008-01-05  3:36     ` Carlo Marcelo Arenas Belon
2008-01-06  9:22       ` Rob Landley
2008-01-07  4:47         ` Carlo Marcelo Arenas Belon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080105020647.GB20718@tapir \
    --to=carenas@sajinet.com.pe \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.