Re: [PATCH] memtest86+ fix

["Yoshinori K. Okuji" <okuji@enbug.org>]

On Thursday 03 January 2008 02:06, Robert Millan wrote:
> On Thu, Jan 03, 2008 at 12:46:15AM +0100, Yoshinori K. Okuji wrote:
> > On Wednesday 02 January 2008 18:05, Robert Millan wrote:
> > > This fixes boot for memtest86+ (and actually, Linux zImages since they
> > > were all affected).
> > >
> > > The problem was that the first code in grub_linux_boot_zimage copied
> > > the payload from  0x100000 to 0x10000.  Since GRUB starts at 0x8200 and
> > > is typicaly more than 8 kiB in size, it'll most likely overwrite part
> > > of it.
> > >
> > > A bit of reestructuring was necessary to allow grub_dl_unload_all() to
> > > happen unconditionally as first step, since the information on whether
> > > this is a "big linux" was not promptly available.
> > >
> > > Comments?
> >
> > It is okay, except for "grub_linux_big"... I cannot figure out what it
> > wants to say. As you want to make it global, please choose a more
> > expressive name, such as "grub_big_linux_loaded".
>
> How about "grub_linux_big_loaded", for consistency with the other vars in
> <machine/kernel.h> that also start with grub_linux_ ?

"big_loaded" sounds horrible to me. How about grub_linux_big_image_loaded?

Okuji