Re: virtio_net backport performance

[Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>]

On Saturday 05 January 2008 09:24:40 Anthony Liguori wrote:
> @@ -215,17 +231,40 @@
>         struct virtnet_info *vi = rvq->vdev->priv;
>         /* Suppress further interrupts. */
>         rvq->vq_ops->disable_cb(rvq);
> +#ifdef COMPAT_napi
> +       vi->rvq->vq_ops->enable_cb(vi->rvq);
> +       if (netif_rx_schedule_prep(vi->dev)) {
> +               vi->rvq->vq_ops->disable_cb(vi->rvq);
> +               __netif_rx_schedule(vi->dev);
> +       } else
> +               vi->rvq->vq_ops->enable_cb(vi->rvq);
> +#else
>         netif_rx_schedule(vi->dev, &vi->napi);
> +#endif
>  }

This looks wrong.  It should be the same, except netif_rx_schedule doesn't 
take the napi arg (the napi struct used to be in the device, but multiqueue 
means everyone need to supply their own napi arg now).

Rusty.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
kvm-devel mailing list
kvm-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/kvm-devel