From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JB7m9-0005cS-Va for mharc-grub-devel@gnu.org; Sat, 05 Jan 2008 07:05:18 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JB7m8-0005c0-D8 for grub-devel@gnu.org; Sat, 05 Jan 2008 07:05:16 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JB7m6-0005bL-9w for grub-devel@gnu.org; Sat, 05 Jan 2008 07:05:15 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JB7m6-0005bG-1j for grub-devel@gnu.org; Sat, 05 Jan 2008 07:05:14 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JB7m5-0000Fq-MZ for grub-devel@gnu.org; Sat, 05 Jan 2008 07:05:13 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JB7m4-0002tK-CK for grub-devel@gnu.org; Sat, 05 Jan 2008 13:05:12 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JB7km-0005KW-Gd for grub-devel@gnu.org; Sat, 05 Jan 2008 13:03:52 +0100 Date: Sat, 5 Jan 2008 13:03:52 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080105120352.GD20032@thorin> References: <20080103150311.GA20790@thorin> <20080103150558.GA21928@thorin> <200801050222.18057.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200801050222.18057.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: variable hooks & global variables X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2008 12:05:16 -0000 On Sat, Jan 05, 2008 at 02:22:17AM +0100, Yoshinori K. Okuji wrote: > On Thursday 03 January 2008 16:05, Robert Millan wrote: > > On Thu, Jan 03, 2008 at 04:03:11PM +0100, Robert Millan wrote: > > > When you set a variable hook (grub_register_variable_hook), this hook > > > isn't preserved after someone (e.g. configfile command) opens a new > > > context (grub_env_context_open), unless the variable has been set as > > > global (grub_env_export). > > > > > > Is this what we want? > > > > > > The only current user of variable hooks is "root" variable, and that hook > > > contains a sanity check that seems to be more suitable for global scope. > > > > > > The color-related variables for which I wanted to add hooks would also > > > like to keep their hooks across contexts. > > > > > > One option is to export these variables, or to modify > > > grub_env_context_open() to preserve hooks as well as exported variables. > > > I'm more inclined for the latter. > > > > > > Comments? > > > > Erm, ignore the part about global variables. Exporting them doesn't help: > > > > for (var = context->prev->vars[i]; var; var = var->next) > > { > > if (var->type == GRUB_ENV_VAR_GLOBAL) > > if (grub_env_set (var->name, var->value) != GRUB_ERR_NONE) > > { > > grub_env_context_close (); > > return grub_errno; > > } > > } > > > > So, we just preserve hooks ? > > Global variables should preserve hooks. This is a bug. Fixed then. > Local ones should not. > If you want to have a variable to be inherited, you must make it global. Ok. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)