From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from moutng.kundenserver.de (moutng.kundenserver.de [212.227.126.174]) by ozlabs.org (Postfix) with ESMTP id 5ACC3DDEBC for ; Sat, 5 Jan 2008 23:54:40 +1100 (EST) From: Arnd Bergmann To: Stefan Roese Subject: Re: [PATCH] i2c-ibm_iic driver Date: Sat, 5 Jan 2008 13:54:09 +0100 References: <477EF225.4070505@pikatech.com> <200801051224.52693.arnd@arndb.de> <200801051349.34488.sr@denx.de> In-Reply-To: <200801051349.34488.sr@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Message-Id: <200801051354.11202.arnd@arndb.de> Cc: linuxppc-dev@ozlabs.org, Sean MacLennan List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Saturday 05 January 2008, Stefan Roese wrote: > > > > This is probably not specific enough. I'm rather sure that someone at I= BM > > has implemented an i2c chip that this driver doesn't support. Maybe > > > > =A0=A0=A0=A0=A0=A0.compatible =3D "ibm,405-iic" > > > > or similar would be a better thing to check for. >=20 > =A0=A0=A0=A0=A0=A0=A0=A0.compatible =3D "ibm,4xx-iic" >=20 > please, since 405 and 440 have the same I2C controller. >=20 But that's not how compatible properties work -- they should not contain wildcards. If you have different devices that are backwards compatible, you should list the older one in all newer devices, e.g. the 440 can list that it is compatible with both ibm,405-iic and ibm,440-iic. If there was an earlier 401 that had iic as well, you may even want to include that in the device tree. Arnd <><