From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JBIhB-0003Du-EM for mharc-grub-devel@gnu.org; Sat, 05 Jan 2008 18:44:53 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JBIh8-00035n-4e for grub-devel@gnu.org; Sat, 05 Jan 2008 18:44:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JBIh3-0002wC-RN for grub-devel@gnu.org; Sat, 05 Jan 2008 18:44:48 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JBIh3-0002v7-86 for grub-devel@gnu.org; Sat, 05 Jan 2008 18:44:45 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JBIh0-0000MV-9P for grub-devel@gnu.org; Sat, 05 Jan 2008 18:44:45 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JBIgR-0002XB-Gp for grub-devel@gnu.org; Sun, 06 Jan 2008 00:44:09 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JBIf2-0001sz-OD for grub-devel@gnu.org; Sun, 06 Jan 2008 00:42:40 +0100 Date: Sun, 6 Jan 2008 00:42:40 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080105234240.GA7078@thorin> References: <20080101124728.GA30417@thorin> <200801030042.01855.okuji@enbug.org> <20080103010414.GC6843@thorin> <20080103153533.GA24992@thorin> <878x342bg5.wl@dekkers.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878x342bg5.wl@dekkers.cx> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] allow user-configurable menucolor X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jan 2008 23:44:51 -0000 On Sat, Jan 05, 2008 at 10:45:46PM +0100, Jeroen Dekkers wrote: > At Thu, 3 Jan 2008 16:35:33 +0100, > Robert Millan wrote: > > diff -x '*~' -x '*.mk' -Nurp grub2/include/grub/normal.h grub2.color/include/grub/normal.h > > --- grub2/include/grub/normal.h 2007-07-22 01:32:22.000000000 +0200 > > +++ grub2.color/include/grub/normal.h 2008-01-03 16:12:53.000000000 +0100 > > @@ -1,7 +1,7 @@ > > /* normal.h - prototypes for the normal mode */ > > /* > > * GRUB -- GRand Unified Bootloader > > - * Copyright (C) 2002,2003,2005,2006,2007 Free Software Foundation, Inc. > > + * Copyright (C) 2002,2003,2005,2006,2007,2008 Free Software Foundation, Inc. > > * > > * GRUB is free software: you can redistribute it and/or modify > > * it under the terms of the GNU General Public License as published by > > @@ -154,6 +154,9 @@ grub_err_t grub_normal_print_device_info > > grub_err_t grub_normal_menu_addentry (const char *title, > > struct grub_script *script, > > const char *sourcecode); > > +char *grub_env_write_color_normal (struct grub_env_var *var, const char *val); > > +char *grub_env_write_color_highlight (struct grub_env_var *var, const char *val); > > +void grub_wait_after_message (void); > > You should actually also include grub/env.h if you use struct > grub_env_var in the prototypes. Uhm, I included it in normal/color.c to satisfy the dependencies: normal/color.c:#include normal/color.c:grub_env_write_color_normal (struct grub_env_var *var __attribute__ ((unused)), normal/color.c:grub_env_write_color_highlight (struct grub_env_var *var __attribute__ ((unused)), but your idea seems better. I suppose we can remove it from there now? > I've fixed that in CVS. Thanks. Btw, nice to see you around here. Do you have any news about the CD-ROM GSoC ? I looked at the tarball from google.com, but CD access seems unfinished (I couldn't access the CD neither in qemu nor in real hw). -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)