Re: [PATCH] mac80211: Add radio led trigger

[Ivo van Doorn <ivdoorn@gmail.com>]

On Monday 07 January 2008, Tomas Winkler wrote:
> On Jan 6, 2008 8:25 PM, Ivo van Doorn <ivdoorn@gmail.com> wrote:
> >
> > On Sunday 06 January 2008, Tomas Winkler wrote:
> > > On Jan 6, 2008 3:10 PM, Ivo van Doorn <ivdoorn@gmail.com> wrote:
> > > > Some devices have a seperate LED which indicates if the radio is
> > > > enabled or not. This adds a LED trigger to mac80211 where drivers
> > > > can hook into when they are interested in radio status changes.
> > > >
> > > >
> > > I wonder how this go together with RF KILL led?
> >
> > They would be competing I fear, but not all devices have a rfkill button,
> > which makes the mac80211 radio led trigger more usefull I think.
> >
> What inquires me is  in the following snippet is  would you lit the
> led if even if rfkill HW switch is on?
> --- a/net/mac80211/ieee80211.c
> +++ b/net/mac80211/ieee80211.c
> @@ -219,6 +219,7 @@ static int ieee80211_open(struct net_device *dev)
>                if (res)
>                        return res;
>                ieee80211_hw_config(local);
> +               ieee80211_led_radio(local, 1);
>        }
> 

Good point. I have updated the patch to make it check the radio_enabled
configuration parameter.

Ivo