All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: intc - remove default interrupt priority tables
Date: Tue, 08 Jan 2008 06:41:45 +0000	[thread overview]
Message-ID: <20080108064145.GA22258@linux-sh.org> (raw)
In-Reply-To: <20080108061240.14389.51112.sendpatchset@clockwork.opensource.se>

On Tue, Jan 08, 2008 at 03:12:40PM +0900, Magnus Damm wrote:
> sh: intc - remove default interrupt priority tables
> 
> This patch removes interrupt priority tables from the intc code. Optimal 
> priority assignment varies with embedded application anyway, so keeping the
> interrupt priority tables together with cpu-specific code doesn't make sense.
> 
> The function intc_set_priority() should be used instead to set the desired
> interrupt priority level.
> 
> Signed-off-by: Magnus Damm <damm@igel.co.jp>

Hmm.. We so have some FPGAs hanging off of IRLs that need a fixed
priority, though I can't think of any CPU subtype off the top of my head
that has that sort of restriction within the core itself. Given that, I
guess this is fine, but that means that the rationale for an intc desc
for an FPGA at a fixed IRL level will be setting the priority from the
board code on the cascade line prior to registration. This makes sense,
but we should probably make a note of it somewhere.

Patch looks ok though, I'll pile it on to my queue.

      reply	other threads:[~2008-01-08  6:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  6:12 [PATCH] sh: intc - remove default interrupt priority tables Magnus Damm
2008-01-08  6:41 ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108064145.GA22258@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.