All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	trivial@kernel.org
Subject: Re: [PATCH 1/5] Codying style fixes in ./arch/x86/ia32
Date: Tue, 8 Jan 2008 11:20:03 +0100	[thread overview]
Message-ID: <20080108102003.GC6906@elte.hu> (raw)
In-Reply-To: <4d8e3fd30801070335n79d910dbt48d0ef0f3597c670@mail.gmail.com>


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

>  int ia32_classify_syscall(unsigned syscall)
>  {
> -       switch(syscall) {
> +       switch (syscall) {
>         case __NR_open:
>                 return 2;
>         case __NR_openat:

this patch has whitespace damage. (tabs got converted to spaces)

i fixed this up, but the other patches in your queue are corrupted too, 
they have linewraps and tabs->spaces problems as well.

also, please use unique subjects for your patches. Instead of:

  Subject: Codying style fixes in ./arch/x86/ia32

use:

  Subject: x86: coding style fixes in arch/x86/ia32/audit.c

(also please keep them lower case)

	Ingo

  reply	other threads:[~2008-01-08 10:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 11:35 [PATCH 1/5] Codying style fixes in ./arch/x86/ia32 Paolo Ciarrocchi
2008-01-08 10:20 ` Ingo Molnar [this message]
2008-01-08 10:24   ` Paolo Ciarrocchi
2008-01-08 10:28     ` Ingo Molnar
2008-01-08 10:41       ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108102003.GC6906@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paolo.ciarrocchi@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.