From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JCC4b-00038c-1i for mharc-grub-devel@gnu.org; Tue, 08 Jan 2008 05:52:45 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCC4Z-00038A-4l for grub-devel@gnu.org; Tue, 08 Jan 2008 05:52:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCC4Y-00037U-0O for grub-devel@gnu.org; Tue, 08 Jan 2008 05:52:42 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCC4X-00037O-Sc for grub-devel@gnu.org; Tue, 08 Jan 2008 05:52:41 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JCC4X-0006GP-PY for grub-devel@gnu.org; Tue, 08 Jan 2008 05:52:41 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JCC4S-0001fI-Ax for grub-devel@gnu.org; Tue, 08 Jan 2008 11:52:38 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JCC2r-0006TR-O1 for grub-devel@gnu.org; Tue, 08 Jan 2008 11:50:57 +0100 Date: Tue, 8 Jan 2008 11:50:57 +0100 From: Robert Millan To: grub-devel@gnu.org Message-ID: <20080108105057.GA24604@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: contradiction in boot/i386/pc/boot.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2008 10:52:43 -0000 boot/i386/pc/boot.S reads: /* * This is a workaround for buggy BIOSes which don't pass boot * drive correctly. If GRUB is installed into a HDD, check if * DL is masked correctly. If not, assume that the BIOS passed * a bogus value and set DL to 0x80, since this is the only * possible boot drive. If GRUB is installed into a floppy, * this does nothing (only jump). */ boot_drive_check: jmp 1f /* grub-setup may overwrite this jump */ testb $0x80, %dl jnz 1f movb $0x80, %dl 1: However, if 0x80 is really "the only possible boot drive", that means the test is pointless and can be replaced with: boot_drive_check: jmp 1f /* grub-setup may overwrite this jump */ movb $0x80, %dl 1: So AFAICT either the comment or the code needs adjusting. -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)