From: Andrew Morton <akpm@linux-foundation.org>
To: Michael Halcrow <mhalcrow@us.ibm.com>
Cc: linux-kernel@vger.kernel.org,
ecryptfs-devel@lists.sourceforge.net, thighlan@gmail.com
Subject: Re: [PATCH] eCryptfs: Load each file decryption key only once
Date: Tue, 8 Jan 2008 14:47:02 -0800 [thread overview]
Message-ID: <20080108144702.a5c0624f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080108211733.GD10989@localhost.austin.ibm.com>
On Tue, 8 Jan 2008 15:17:33 -0600
Michael Halcrow <mhalcrow@us.ibm.com> wrote:
> On Fri, Dec 21, 2007 at 08:05:30PM -0600, Trevor Highland wrote:
> > eCryptfs: Load each file decryption key only once
> >
> > There is no need to keep re-setting the same key for any given
> > eCryptfs inode. This patch optimizes the use of the crypto API and
> > helps performance a bit.
>
> There is no reason for the crypt_stat->key value for any given
> eCryptfs inode to change during the life of the inode, and each
> crypt_stat gets its own crypto transform, so I do not see a problem
> with Trevor's suggestion. It will save unnecessary calls to
> crypto_blkcipher_setkey(), and I expect it will speed things up a
> little.
>
> I include an updated patch against 2.6.24-rc7.
>
Your new patch clashes horridly with the pending
ecryptfs-set-inode-key-only-once-per-crypto-operation.patch.
I shall drop ecryptfs-load-each-file-decryption-key-only-once.patch and shall
then sit back and sulk.
next prev parent reply other threads:[~2008-01-08 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-22 2:05 [PATCH] eCryptfs: Load each file decryption key only once Trevor Highland
2008-01-08 21:17 ` Michael Halcrow
2008-01-08 22:47 ` Andrew Morton [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-19 2:37 Trevor Highland
2007-12-18 6:11 Trevor Highland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108144702.a5c0624f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=ecryptfs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mhalcrow@us.ibm.com \
--cc=thighlan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.