From: Ingo Molnar <mingo@elte.hu>
To: DM <dm.n9107@gmail.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
linux-kernel@vger.kernel.org, rusty@rustcorp.com.au, ak@suse.de
Subject: Re: [patch 2/2] track and print last unloaded module in the oops trace
Date: Tue, 8 Jan 2008 17:18:46 +0100 [thread overview]
Message-ID: <20080108161846.GD32273@elte.hu> (raw)
In-Reply-To: <5eeb9ad90801080639h2992e9b7maec0339e4f763f65@mail.gmail.com>
* DM <dm.n9107@gmail.com> wrote:
> On Jan 8, 2008 3:26 PM, Arjan van de Ven <arjan@infradead.org> wrote:
> > >
> > > Why use sprintf? If a module name contains the % character we could
> > > overflow the buffer. Or is module-unloading root-only and we don't
> > > care?
> >
> > module loading isn't just root only; the name comes from an already loaded module.
> > If you can load kernel modules of your choice you own the entire kernel already anway
> >
>
> Still, strcpy seems like a better choice IMHO.
agreed, this just isnt obvious IMO:
+ sprintf(last_unloaded_module, mod->name);
Ingo
next prev parent reply other threads:[~2008-01-08 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-06 23:19 [patch 2/2] track and print last unloaded module in the oops trace Arjan van de Ven
2008-01-07 1:25 ` Rusty Russell
2008-01-08 11:23 ` Ingo Molnar
2008-01-08 11:52 ` Rusty Russell
2008-01-08 13:51 ` DM
2008-01-08 14:26 ` Arjan van de Ven
2008-01-08 14:39 ` DM
2008-01-08 16:18 ` Ingo Molnar [this message]
2008-01-08 21:20 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108161846.GD32273@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=arjan@infradead.org \
--cc=dm.n9107@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.