From: Scott Wood <scottwood@freescale.com>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Stefan Roese <sr@denx.de>, Arnd Bergmann <arnd@arndb.de>,
linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] i2c-ibm_iic driver - new patch
Date: Tue, 8 Jan 2008 10:40:44 -0600 [thread overview]
Message-ID: <20080108164044.GA4949@loki.buserror.net> (raw)
In-Reply-To: <4783108B.6070308@pikatech.com>
On Tue, Jan 08, 2008 at 12:56:27AM -0500, Sean MacLennan wrote:
> Stephen Rothwell wrote:
> > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <smaclennan@pikatech.com> wrote:
> >> +static int __devinit iic_probe(struct of_device *ofdev,
> >> + const struct of_device_id *match)
> >>
> >
> > Indenting could be better.
> >
> Sorry. Since this kernel is in a "work" directory and not in
> /usr/src/linux* my rules for deciding on the tab size didn't work :( I
> tried to correct the tabbing.
Better to tab to the semantic indentation level (in this case there is
none), and then use spaces to align -- that way it looks right regardless of
what the tab size is set to.
-Scott
next prev parent reply other threads:[~2008-01-08 16:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-05 2:57 [PATCH] i2c-ibm_iic driver Sean MacLennan
2008-01-05 11:24 ` Arnd Bergmann
2008-01-05 12:49 ` Stefan Roese
2008-01-05 12:54 ` Arnd Bergmann
2008-01-05 12:58 ` Stefan Roese
2008-01-05 18:36 ` Sean MacLennan
2008-01-05 19:18 ` Arnd Bergmann
2008-01-06 0:12 ` David Gibson
2008-01-08 2:03 ` [PATCH] i2c-ibm_iic driver - new patch Sean MacLennan
2008-01-08 4:52 ` Stephen Rothwell
2008-01-08 5:56 ` Sean MacLennan
2008-01-08 6:36 ` Stephen Rothwell
2008-01-08 18:35 ` Sean MacLennan
2008-01-08 19:33 ` Stefan Roese
2008-01-08 16:40 ` Scott Wood [this message]
2008-01-05 18:32 ` [PATCH] i2c-ibm_iic driver Sean MacLennan
2008-01-05 18:30 ` Sean MacLennan
2008-01-08 1:16 ` Sean MacLennan
2008-02-19 2:02 ` [PATCH] i2c-ibm_iic driver bonus patch Sean MacLennan
2008-02-19 3:27 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108164044.GA4949@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=arnd@arndb.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
--cc=smaclennan@pikatech.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.