From: Sam Ravnborg <sam@ravnborg.org>
To: Daniel Walker <dwalker@mvista.com>
Cc: Theodore Tso <tytso@mit.edu>, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, apw@shadowen.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] Deprecate checkpatch.pl --file
Date: Tue, 8 Jan 2008 20:21:42 +0100 [thread overview]
Message-ID: <20080108192142.GA26491@uranus.ravnborg.org> (raw)
In-Reply-To: <1199817208.1756.47.camel@imap.mvista.com>
>
> What I was saying in my first email was we can throttle "patches"
> arbitrarily (I think Andrew/Linus even have a merge period for these
> types of patches) .. So that's not the issue .. I feel style clean ups
> are fundamentally good.. So what we don't want to do is discourage the
> creation of good patches, which is what I think Andi is doing..
The way I read this:
+WARNING: Using --file mode. Please do not send patches to linux-kernel
+that change whole existing files if you did not significantly change most
+of the the file for other reasons anyways or just wrote the file newly
+from scratch. Pure code style patches have a significant cost in a
+quickly changing code base like Linux because they cause rejects
+with other changes.
does not discourage the creation of good patches.
But is discourage the creation of pure clean-up patches because it
may have a disturbing effect on several other peoples work.
Sam
next prev parent reply other threads:[~2008-01-08 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:14 [PATCH] Deprecate checkpatch.pl --file Andi Kleen
2008-01-08 16:50 ` Daniel Walker
2008-01-08 17:53 ` Sam Ravnborg
2008-01-08 18:01 ` Daniel Walker
2008-01-08 18:20 ` Theodore Tso
2008-01-08 18:33 ` Daniel Walker
2008-01-08 19:21 ` Sam Ravnborg [this message]
2008-01-08 19:27 ` Andi Kleen
2008-01-08 20:19 ` Daniel Walker
2008-01-08 21:14 ` Theodore Tso
2008-01-08 21:50 ` Daniel Walker
2008-01-08 20:27 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108192142.GA26491@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=apw@shadowen.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.