From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JCL1s-0000UB-LZ for mharc-grub-devel@gnu.org; Tue, 08 Jan 2008 15:26:32 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JCL1r-0000Tr-Sy for grub-devel@gnu.org; Tue, 08 Jan 2008 15:26:31 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JCL1q-0000T1-1u for grub-devel@gnu.org; Tue, 08 Jan 2008 15:26:31 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JCL1p-0000Sw-Pa for grub-devel@gnu.org; Tue, 08 Jan 2008 15:26:29 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JCL1p-0007cL-Ng for grub-devel@gnu.org; Tue, 08 Jan 2008 15:26:29 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JCL1m-0002eZ-V7 for grub-devel@gnu.org; Tue, 08 Jan 2008 21:26:28 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JCL0J-0005yH-Fn for grub-devel@gnu.org; Tue, 08 Jan 2008 21:24:55 +0100 Date: Tue, 8 Jan 2008 21:24:55 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080108202455.GA22878@thorin> References: <20080108105057.GA24604@thorin> <1199816665.30874.13.camel@dv> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1199816665.30874.13.camel@dv> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: contradiction in boot/i386/pc/boot.S X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jan 2008 20:26:32 -0000 On Tue, Jan 08, 2008 at 01:24:25PM -0500, Pavel Roskin wrote: > On Tue, 2008-01-08 at 11:50 +0100, Robert Millan wrote: > > boot_drive_check: > > jmp 1f /* grub-setup may overwrite this jump */ > > testb $0x80, %dl > > jnz 1f > > movb $0x80, %dl > > 1: > > > > However, if 0x80 is really "the only possible boot drive", that means the > > test is pointless and can be replaced with: > > No, I was wrong, I misread "testb" as "cmpb". Values such as 0x81 are > valid and should be preserved. Yeah I was going to point that.. > Please ignore my previous message. All of it, or just partly ? -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)