From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: [patch 07/19] (NEW) add some sanity checks to get_scan_ratio
Date: Tue, 08 Jan 2008 15:59:46 -0500 [thread overview]
Message-ID: <20080108210005.558041779@redhat.com> (raw)
In-Reply-To: 20080108205939.323955454@redhat.com
[-- Attachment #1: rvr-04-linux-2.6-scan-ratio-fixes.patch --]
[-- Type: text/plain, Size: 1445 bytes --]
The access ratio based scan rate determination in get_scan_ratio
works ok in most situations, but needs to be corrected in some
corner cases:
- if we run out of swap space, do not bother scanning the anon LRUs
- if we have already freed all of the page cache, we need to scan
the anon LRUs
Signed-off-by: Rik van Riel <riel@redhat.com>
Index: linux-2.6.24-rc6-mm1/mm/vmscan.c
===================================================================
--- linux-2.6.24-rc6-mm1.orig/mm/vmscan.c 2008-01-07 17:33:50.000000000 -0500
+++ linux-2.6.24-rc6-mm1/mm/vmscan.c 2008-01-07 17:57:49.000000000 -0500
@@ -1182,7 +1182,7 @@ static unsigned long shrink_list(enum lr
static void get_scan_ratio(struct zone *zone, struct scan_control * sc,
unsigned long *percent)
{
- unsigned long anon, file;
+ unsigned long anon, file, free;
unsigned long anon_prio, file_prio;
unsigned long rotate_sum;
unsigned long ap, fp;
@@ -1230,6 +1230,20 @@ static void get_scan_ratio(struct zone *
else if (fp > 100)
fp = 100;
percent[1] = fp;
+
+ free = zone_page_state(zone, NR_FREE_PAGES);
+
+ /*
+ * If we have no swap space, do not bother scanning anon pages
+ */
+ if (nr_swap_pages <= 0)
+ percent[0] = 0;
+ /*
+ * If we already freed most file pages, scan the anon pages
+ * regardless of the page access ratios or swappiness setting.
+ */
+ else if (file + free <= zone->pages_high)
+ percent[0] = 100;
}
--
All Rights Reversed
WARNING: multiple messages have this Message-ID (diff)
From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org
Subject: [patch 07/19] (NEW) add some sanity checks to get_scan_ratio
Date: Tue, 08 Jan 2008 15:59:46 -0500 [thread overview]
Message-ID: <20080108210005.558041779@redhat.com> (raw)
In-Reply-To: 20080108205939.323955454@redhat.com
[-- Attachment #1: rvr-04-linux-2.6-scan-ratio-fixes.patch --]
[-- Type: text/plain, Size: 1670 bytes --]
The access ratio based scan rate determination in get_scan_ratio
works ok in most situations, but needs to be corrected in some
corner cases:
- if we run out of swap space, do not bother scanning the anon LRUs
- if we have already freed all of the page cache, we need to scan
the anon LRUs
Signed-off-by: Rik van Riel <riel@redhat.com>
Index: linux-2.6.24-rc6-mm1/mm/vmscan.c
===================================================================
--- linux-2.6.24-rc6-mm1.orig/mm/vmscan.c 2008-01-07 17:33:50.000000000 -0500
+++ linux-2.6.24-rc6-mm1/mm/vmscan.c 2008-01-07 17:57:49.000000000 -0500
@@ -1182,7 +1182,7 @@ static unsigned long shrink_list(enum lr
static void get_scan_ratio(struct zone *zone, struct scan_control * sc,
unsigned long *percent)
{
- unsigned long anon, file;
+ unsigned long anon, file, free;
unsigned long anon_prio, file_prio;
unsigned long rotate_sum;
unsigned long ap, fp;
@@ -1230,6 +1230,20 @@ static void get_scan_ratio(struct zone *
else if (fp > 100)
fp = 100;
percent[1] = fp;
+
+ free = zone_page_state(zone, NR_FREE_PAGES);
+
+ /*
+ * If we have no swap space, do not bother scanning anon pages
+ */
+ if (nr_swap_pages <= 0)
+ percent[0] = 0;
+ /*
+ * If we already freed most file pages, scan the anon pages
+ * regardless of the page access ratios or swappiness setting.
+ */
+ else if (file + free <= zone->pages_high)
+ percent[0] = 100;
}
--
All Rights Reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2008-01-08 21:14 UTC|newest]
Thread overview: 148+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 20:59 [patch 00/19] VM pageout scalability improvements Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 01/19] move isolate_lru_page() to vmscan.c Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:03 ` Christoph Lameter
2008-01-08 22:03 ` Christoph Lameter
2008-01-08 20:59 ` [patch 02/19] free swap space on swap-in/activation Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:10 ` Christoph Lameter
2008-01-08 22:10 ` Christoph Lameter
2008-01-08 20:59 ` [patch 03/19] define page_file_cache() function Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:18 ` Christoph Lameter
2008-01-08 22:18 ` Christoph Lameter
2008-01-08 22:28 ` Rik van Riel
2008-01-08 22:28 ` Rik van Riel
2008-01-09 4:26 ` KAMEZAWA Hiroyuki
2008-01-09 4:26 ` KAMEZAWA Hiroyuki
2008-01-08 20:59 ` [patch 04/19] Use an indexed array for LRU variables Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 05/19] split LRU lists into anon & file sets Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:22 ` Christoph Lameter
2008-01-08 22:22 ` Christoph Lameter
2008-01-08 22:36 ` Rik van Riel
2008-01-08 22:36 ` Rik van Riel
2008-01-08 22:42 ` Christoph Lameter
2008-01-08 22:42 ` Christoph Lameter
2008-01-09 2:45 ` Rik van Riel
2008-01-09 2:45 ` Rik van Riel
2008-01-09 4:41 ` KAMEZAWA Hiroyuki
2008-01-09 4:41 ` KAMEZAWA Hiroyuki
2008-01-10 2:21 ` Balbir Singh
2008-01-10 2:21 ` Balbir Singh
2008-01-10 2:36 ` KAMEZAWA Hiroyuki
2008-01-10 2:36 ` KAMEZAWA Hiroyuki
2008-01-10 3:26 ` Balbir Singh
2008-01-10 3:26 ` Balbir Singh
2008-01-10 4:23 ` KAMEZAWA Hiroyuki
2008-01-10 4:23 ` KAMEZAWA Hiroyuki
2008-01-10 2:28 ` KAMEZAWA Hiroyuki
2008-01-10 2:28 ` KAMEZAWA Hiroyuki
2008-01-10 2:37 ` Rik van Riel
2008-01-10 2:37 ` Rik van Riel
2008-01-11 3:59 ` KOSAKI Motohiro
2008-01-11 3:59 ` KOSAKI Motohiro
2008-01-11 15:37 ` Rik van Riel
2008-01-11 15:37 ` Rik van Riel
2008-01-11 6:24 ` KOSAKI Motohiro
2008-01-11 6:24 ` KOSAKI Motohiro
2008-01-11 15:42 ` Rik van Riel
2008-01-11 15:42 ` Rik van Riel
2008-01-11 15:59 ` Lee Schermerhorn
2008-01-11 15:59 ` Lee Schermerhorn
2008-01-11 16:15 ` Rik van Riel
2008-01-11 16:15 ` Rik van Riel
2008-01-11 19:51 ` Lee Schermerhorn
2008-01-11 19:51 ` Lee Schermerhorn
2008-01-11 15:50 ` Lee Schermerhorn
2008-01-11 15:50 ` Lee Schermerhorn
2008-01-11 16:06 ` Rik van Riel
2008-01-11 16:06 ` Rik van Riel
2008-01-11 7:35 ` KOSAKI Motohiro
2008-01-11 7:35 ` KOSAKI Motohiro
2008-01-11 15:46 ` Rik van Riel
2008-01-11 15:46 ` Rik van Riel
2008-01-14 23:57 ` KOSAKI Motohiro
2008-01-14 23:57 ` KOSAKI Motohiro
2008-01-30 3:25 ` KOSAKI Motohiro
2008-01-30 3:25 ` KOSAKI Motohiro
2008-01-30 8:57 ` KOSAKI Motohiro
2008-01-30 8:57 ` KOSAKI Motohiro
2008-01-30 14:29 ` Lee Schermerhorn
2008-01-30 14:29 ` Lee Schermerhorn
2008-01-31 1:17 ` KOSAKI Motohiro
2008-01-31 1:17 ` KOSAKI Motohiro
2008-01-31 10:48 ` Rik van Riel
2008-01-31 10:48 ` Rik van Riel
2008-01-31 10:59 ` KOSAKI Motohiro
2008-01-31 10:59 ` KOSAKI Motohiro
2008-02-07 0:35 ` Rik van Riel
2008-02-07 0:35 ` Rik van Riel
2008-02-07 1:20 ` KOSAKI Motohiro
2008-02-07 1:20 ` KOSAKI Motohiro
2008-02-07 1:36 ` Rik van Riel
2008-02-07 1:36 ` Rik van Riel
2008-01-08 20:59 ` [patch 06/19] SEQ replacement for anonymous pages Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` Rik van Riel [this message]
2008-01-08 20:59 ` [patch 07/19] (NEW) add some sanity checks to get_scan_ratio Rik van Riel
2008-01-09 4:16 ` KAMEZAWA Hiroyuki
2008-01-09 4:16 ` KAMEZAWA Hiroyuki
2008-01-09 12:53 ` Rik van Riel
2008-01-09 12:53 ` Rik van Riel
2008-01-08 20:59 ` [patch 08/19] add newly swapped in pages to the inactive list Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:28 ` Christoph Lameter
2008-01-08 22:28 ` Christoph Lameter
2008-01-08 20:59 ` [patch 09/19] (NEW) more aggressively use lumpy reclaim Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 22:30 ` Christoph Lameter
2008-01-08 22:30 ` Christoph Lameter
2008-01-14 15:28 ` Mel Gorman
2008-01-14 15:28 ` Mel Gorman
2008-01-08 20:59 ` [patch 10/19] No Reclaim LRU Infrastructure Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-11 4:36 ` KOSAKI Motohiro
2008-01-11 4:36 ` KOSAKI Motohiro
2008-01-11 15:43 ` Lee Schermerhorn
2008-01-11 15:43 ` Lee Schermerhorn
2008-01-15 0:06 ` KOSAKI Motohiro
2008-01-15 0:06 ` KOSAKI Motohiro
2008-01-08 20:59 ` [patch 11/19] Non-reclaimable page statistics Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 12/19] scan noreclaim list for reclaimable pages Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 13/19] ramfs pages are non-reclaimable Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 14/19] SHM_LOCKED pages are nonreclaimable Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 15/19] non-reclaimable mlocked pages Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 16/19] mlock vma pages under mmap_sem held for read Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 17/19] handle mlocked pages during map/unmap and truncate Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-08 20:59 ` [patch 18/19] account mlocked pages Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-11 12:51 ` Balbir Singh
2008-01-11 12:51 ` Balbir Singh
2008-01-13 5:18 ` Rik van Riel
2008-01-13 5:18 ` Rik van Riel
2008-01-08 20:59 ` [patch 19/19] cull non-reclaimable anon pages from the LRU at fault time Rik van Riel
2008-01-08 20:59 ` Rik van Riel
2008-01-10 4:39 ` [patch 00/19] VM pageout scalability improvements Mike Snitzer
2008-01-10 4:39 ` Mike Snitzer
2008-01-10 15:41 ` Rik van Riel
2008-01-10 15:41 ` Rik van Riel
2008-01-10 16:08 ` Mike Snitzer
2008-01-10 16:08 ` Mike Snitzer
2008-01-11 10:41 ` Balbir Singh
2008-01-11 10:41 ` Balbir Singh
2008-01-11 15:38 ` Rik van Riel
2008-01-11 15:38 ` Rik van Riel
2008-01-11 11:47 ` Balbir Singh
2008-01-11 11:47 ` Balbir Singh
2008-01-16 6:17 ` rvr split LRU minor regression ? KOSAKI Motohiro
2008-01-16 6:17 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080108210005.558041779@redhat.com \
--to=riel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.