All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Jim Keniston <jkenisto@us.ibm.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	ananth@in.ibm.com, akpm@linux-foundation.org,
	lkml <linux-kernel@vger.kernel.org>,
	mingo@elte.hu, mhiramat@redhat.com, davem@davemloft.net,
	hskinnemoen@atmel.com
Subject: Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot
Date: Wed, 9 Jan 2008 00:28:41 +0100	[thread overview]
Message-ID: <20080108232841.GD2117@one.firstfloor.org> (raw)
In-Reply-To: <1199833842.3914.33.camel@dyn9047018096.beaverton.ibm.com>

> I have no problem with that, but if we want to make it buildable as a
> module, the call to get_kprobe() needs to be replaced with some other
> gcc-inline-defeating mechanism, or we need to export get_probe().  I

It's still unclear where noinline does not work (do you have details on that? 
It sounds a little dubious) but there are lots of different other ways to prevent gcc 
from inlining anything.

e.g. you can use stdarg or computed goto or a variable length local array 


> much prefer the former, since get_kprobe() is a kprobes-internal
> function.
> 
> Anybody know an architecture-independent way (other than noinline, which
> doesn't always work) of making gcc decide not to inline a function?

Details?

> E.g., does taking (and using) the function's address do it?

No, that just creates another out of line copy.

-Andi

  reply	other threads:[~2008-01-08 23:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  6:33 [PATCH] Kprobes: Add kprobes smoke tests that run on boot Ananth N Mavinakayanahalli
2008-01-08  9:15 ` Ingo Molnar
2008-01-08 21:00 ` Andi Kleen
2008-01-08 22:18   ` Ingo Molnar
2008-01-08 22:49     ` Andi Kleen
2008-01-08 22:50       ` Ingo Molnar
2008-01-09  8:00     ` Christoph Hellwig
2008-01-09  8:08       ` Sam Ravnborg
2008-01-08 23:10   ` Jim Keniston
2008-01-08 23:28     ` Andi Kleen [this message]
2008-01-09 20:24       ` Jim Keniston
2008-01-09 21:21         ` Andi Kleen
2008-01-09 22:33           ` Jim Keniston
2008-01-09  7:43 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108232841.GD2117@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=davem@davemloft.net \
    --cc=hskinnemoen@atmel.com \
    --cc=jkenisto@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.