From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759230AbYAIBGA (ORCPT ); Tue, 8 Jan 2008 20:06:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758011AbYAIA7f (ORCPT ); Tue, 8 Jan 2008 19:59:35 -0500 Received: from mx2.mail.elte.hu ([157.181.151.9]:53326 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757884AbYAIA7c (ORCPT ); Tue, 8 Jan 2008 19:59:32 -0500 Date: Wed, 9 Jan 2008 01:59:15 +0100 From: Ingo Molnar To: Jeremy Fitzhardinge Cc: LKML , Andi Kleen , Glauber de Oliveira Costa , Jan Beulich Subject: Re: [PATCH 00 of 10] x86: unify asm/pgtable.h Message-ID: <20080109005914.GA24228@elte.hu> References: <20080108231226.GA10744@elte.hu> <478405DA.40303@goop.org> <20080108232803.GA19906@elte.hu> <20080108234449.GA24274@elte.hu> <20080109000146.GA29095@elte.hu> <47841194.2010208@goop.org> <20080109002014.GB31289@elte.hu> <20080109002803.GA3732@elte.hu> <20080109003034.GA4658@elte.hu> <47841B09.3020507@goop.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <47841B09.3020507@goop.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Jeremy Fitzhardinge wrote: > In other words, prot and ref_prot can never be equal, so this path is > always taken, and the other branch which tests pte_huge() is never > run. > > Andi? Jan? Is this code just buggy, or is there something else going > on here? this code is plain buggy but fixing it triggered driver bugs in the past so we've been procrastinating it forever ... Ingo