From: Arnd Bergmann <arnd@arndb.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org, apw@shadowen.org
Subject: Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl
Date: Wed, 9 Jan 2008 01:40:58 +0100 [thread overview]
Message-ID: <200801090140.58864.arnd@arndb.de> (raw)
In-Reply-To: <20080108191843.GA1004@one.firstfloor.org>
On Tuesday 08 January 2008, Andi Kleen wrote:
> > Thanks, Andi! I think it'd very useful change.
>
> Reminds me this is something that should be actually flagged
> in checkpatch.pl too
>
> Andy, it would be good if checkpatch.pl complained about .ioctl =
> as opposed to .unlocked_ioctl = ...
This is rather hard, as there are different data structures that
all contain ->ioctl and/or ->unlocked_ioctl function pointers.
Some of them already use ->ioctl in an unlocked fashion only,
so blindly warning about this would give lots of false positives.
> Also perhaps if a whole new file_operations with a ioctl is added
> complain about missing compat_ioctl as a low prioritity warning?
> (might be ok if it's architecture specific on architectures without
> compat layer)
Also, not every data structure that provides a ->ioctl callback
also has a ->compat_ioctl, although there should be fewer exceptions
here.
Arnd <><
next prev parent reply other threads:[~2008-01-09 0:41 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 16:40 [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Andi Kleen
2008-01-08 16:40 ` Andi Kleen
2008-01-08 17:05 ` Cyrill Gorcunov
2008-01-08 17:05 ` Cyrill Gorcunov
2008-01-08 18:52 ` Alexey Dobriyan
2008-01-08 18:52 ` Alexey Dobriyan
2008-01-08 19:18 ` Andi Kleen
2008-01-09 0:40 ` Arnd Bergmann [this message]
2008-01-09 0:47 ` Andi Kleen
2008-01-09 1:19 ` Arnd Bergmann
2008-01-09 1:31 ` Kevin Winchester
2008-01-09 1:41 ` Andi Kleen
2008-01-09 8:02 ` Christoph Hellwig
2008-01-09 10:00 ` Junio C Hamano
[not found] ` <200801091255.02172.arnd@arndb.de>
2008-01-09 14:06 ` Andi Kleen
2008-01-08 19:58 ` Paolo Ciarrocchi
2008-01-08 19:58 ` Paolo Ciarrocchi
2008-01-08 20:00 ` Matthew Wilcox
2008-01-08 20:00 ` Matthew Wilcox
2008-01-08 20:03 ` Paolo Ciarrocchi
2008-01-08 20:03 ` Paolo Ciarrocchi
2008-01-08 20:16 ` Matthew Wilcox
2008-01-08 20:16 ` Matthew Wilcox
2008-01-08 20:21 ` Matthew Wilcox
2008-01-08 20:21 ` Matthew Wilcox
2008-01-08 20:26 ` Paolo Ciarrocchi
2008-01-08 20:26 ` Paolo Ciarrocchi
2008-01-08 23:55 ` Dmitri Vorobiev
2008-01-08 23:55 ` Dmitri Vorobiev
2008-03-06 14:54 ` supervising, text processing, semantic "patching" (Re: [JANITOR PROPOSAL] Switch ioctl functions to Oleg Verych
2008-03-06 14:54 ` supervising, text processing, semantic "patching" (Re: [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl) Oleg Verych
2008-01-08 20:22 ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Rik van Riel
2008-01-08 20:22 ` Rik van Riel
2008-01-08 20:42 ` Andi Kleen
2008-01-08 20:42 ` Andi Kleen
2008-01-08 20:45 ` Paolo Ciarrocchi
2008-01-08 20:45 ` Paolo Ciarrocchi
2008-01-08 23:06 ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl II Andi Kleen
2008-01-08 23:06 ` Andi Kleen
2008-01-08 23:43 ` Paolo Ciarrocchi
2008-01-08 23:43 ` Paolo Ciarrocchi
2008-01-09 0:03 ` Andi Kleen
2008-01-09 0:03 ` Andi Kleen
2008-01-09 20:12 ` [JANITOR PROPOSAL] Switch ioctl functions to ->unlocked_ioctl Matt Mackall
2008-01-09 20:12 ` Matt Mackall
2008-01-09 22:40 ` Alasdair G Kergon
2008-01-09 22:40 ` Alasdair G Kergon
2008-01-09 22:46 ` Andi Kleen
2008-01-09 22:46 ` Andi Kleen
2008-01-09 22:45 ` Alasdair G Kergon
2008-01-09 22:45 ` Alasdair G Kergon
2008-01-09 22:58 ` Chris Friesen
2008-01-09 22:58 ` Chris Friesen
2008-01-09 23:05 ` Alasdair G Kergon
2008-01-09 23:05 ` Alasdair G Kergon
2008-01-09 23:31 ` Vadim Lobanov
2008-01-09 23:31 ` Vadim Lobanov
2008-01-10 0:00 ` Alasdair G Kergon
2008-01-10 4:59 ` Vadim Lobanov
2008-01-10 4:59 ` Vadim Lobanov
2008-01-10 8:34 ` Christoph Hellwig
2008-01-10 9:49 ` Daniel Phillips
2008-01-10 9:49 ` Daniel Phillips
2008-01-10 11:39 ` Alasdair G Kergon
2008-01-10 22:55 ` Daniel Phillips
2008-01-10 22:55 ` Daniel Phillips
2008-01-11 8:33 ` Pavel Machek
2008-01-08 23:50 ` Kevin Winchester
2008-01-08 23:50 ` Kevin Winchester
2008-01-09 0:09 ` Andi Kleen
2008-01-09 0:09 ` Andi Kleen
2008-01-09 0:17 ` Kevin Winchester
2008-01-09 0:17 ` Kevin Winchester
2008-01-09 0:27 ` Andi Kleen
2008-01-09 0:27 ` Andi Kleen
2008-01-09 10:34 ` Andre Noll
2008-01-09 10:34 ` Andre Noll
2008-01-09 13:17 ` Richard Knutsson
2008-01-09 13:17 ` Richard Knutsson
2008-01-09 13:33 ` Andre Noll
2008-01-09 13:33 ` Andre Noll
2008-01-10 8:52 ` Rolf Eike Beer
2008-01-10 8:52 ` Rolf Eike Beer
2008-01-10 9:25 ` Andi Kleen
2008-01-10 9:25 ` Andi Kleen
2008-01-10 10:02 ` Rolf Eike Beer
2008-01-10 10:02 ` Rolf Eike Beer
2008-01-10 10:06 ` Andi Kleen
2008-01-10 10:06 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801090140.58864.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=adobriyan@gmail.com \
--cc=andi@firstfloor.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.