From: Andi Kleen <andi@firstfloor.org>
To: Dave Airlie <airlied@linux.ie>
Cc: Kevin Winchester <kjwinchester@gmail.com>,
dri-devel@lists.sourceforge.net, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl
Date: Wed, 09 Jan 2008 04:11:35 +0000 [thread overview]
Message-ID: <20080109041135.GA7130@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.0.82.0801090336000.9570@skynet.skynet.ie>
On Wed, Jan 09, 2008 at 03:37:50AM +0000, Dave Airlie wrote:
>
> > The drm drivers in this patch all used drm_ioctl to perform their
> > ioctl calls. The common function is converted to use lock_kernel()
> > and unlock_kernel() and the drivers are converted to use .unlocked_ioctl
> >
>
> NAK
Did you actually read Kevin's patch?
>
> I've started looking at this already in the drm git tree, I'm going to
> provide both locked and unlocked paths for drivers to choose, as we need
If you do that you'll exactly need Kevin's patch as a base.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Dave Airlie <airlied@linux.ie>
Cc: Kevin Winchester <kjwinchester@gmail.com>,
dri-devel@lists.sourceforge.net, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl
Date: Wed, 9 Jan 2008 05:11:35 +0100 [thread overview]
Message-ID: <20080109041135.GA7130@one.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.0.82.0801090336000.9570@skynet.skynet.ie>
On Wed, Jan 09, 2008 at 03:37:50AM +0000, Dave Airlie wrote:
>
> > The drm drivers in this patch all used drm_ioctl to perform their
> > ioctl calls. The common function is converted to use lock_kernel()
> > and unlock_kernel() and the drivers are converted to use .unlocked_ioctl
> >
>
> NAK
Did you actually read Kevin's patch?
>
> I've started looking at this already in the drm git tree, I'm going to
> provide both locked and unlocked paths for drivers to choose, as we need
If you do that you'll exactly need Kevin's patch as a base.
-Andi
next prev parent reply other threads:[~2008-01-09 4:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080109005416.039551758@gmail.com>
2008-01-09 0:54 ` [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl Kevin Winchester
2008-01-09 0:54 ` Kevin Winchester
2008-01-09 3:37 ` [patch 1/1] Convert drivers in drivers/char/drm to use Dave Airlie
2008-01-09 3:37 ` [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl Dave Airlie
2008-01-09 4:11 ` Andi Kleen [this message]
2008-01-09 4:11 ` Andi Kleen
2008-01-09 4:51 ` [patch 1/1] Convert drivers in drivers/char/drm to use Dave Airlie
2008-01-09 4:51 ` [patch 1/1] Convert drivers in drivers/char/drm to use .unlocked_ioctl Dave Airlie
2008-01-09 12:28 ` Kevin Winchester
2008-01-09 12:28 ` Kevin Winchester
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109041135.GA7130@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kjwinchester@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.