From: Sam Ravnborg <sam@ravnborg.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
ananth@in.ibm.com, akpm@linux-foundation.org,
lkml <linux-kernel@vger.kernel.org>,
Jim Keniston <jkenisto@us.ibm.com>,
mhiramat@redhat.com, davem@davemloft.net, hskinnemoen@atmel.com
Subject: Re: [PATCH] Kprobes: Add kprobes smoke tests that run on boot
Date: Wed, 9 Jan 2008 09:08:00 +0100 [thread overview]
Message-ID: <20080109080800.GA32035@uranus.ravnborg.org> (raw)
In-Reply-To: <20080109080003.GC32560@infradead.org>
On Wed, Jan 09, 2008 at 08:00:03AM +0000, Christoph Hellwig wrote:
> On Tue, Jan 08, 2008 at 11:18:02PM +0100, Ingo Molnar wrote:
> >
> > * Andi Kleen <andi@firstfloor.org> wrote:
> >
> > > Ananth N Mavinakayanahalli <ananth@in.ibm.com> writes:
> > > > kernel/kprobes.c | 2
> > > > kernel/test_kprobes.c | 216 ++++++++++++++++++++++++++++++++++++++++++++++++
> > >
> > > Can you put this somewhere else please? I know there are already some
> > > test files in kernel/* but imho they all belong into some other
> > > directory.
> >
> > agreed - lib/* would be the right place i think - we've got
> > lib/locking-selftest.c already.
>
> Actually the right place would be to have a separate toplevel directory
> I think, and a separate menu in the kernel config machinery. Thay way
> tests are in one place and easily spottable.
Seconded...
Sam
next prev parent reply other threads:[~2008-01-09 8:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 6:33 [PATCH] Kprobes: Add kprobes smoke tests that run on boot Ananth N Mavinakayanahalli
2008-01-08 9:15 ` Ingo Molnar
2008-01-08 21:00 ` Andi Kleen
2008-01-08 22:18 ` Ingo Molnar
2008-01-08 22:49 ` Andi Kleen
2008-01-08 22:50 ` Ingo Molnar
2008-01-09 8:00 ` Christoph Hellwig
2008-01-09 8:08 ` Sam Ravnborg [this message]
2008-01-08 23:10 ` Jim Keniston
2008-01-08 23:28 ` Andi Kleen
2008-01-09 20:24 ` Jim Keniston
2008-01-09 21:21 ` Andi Kleen
2008-01-09 22:33 ` Jim Keniston
2008-01-09 7:43 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109080800.GA32035@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@in.ibm.com \
--cc=andi@firstfloor.org \
--cc=davem@davemloft.net \
--cc=hch@infradead.org \
--cc=hskinnemoen@atmel.com \
--cc=jkenisto@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.