From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Date: Wed, 09 Jan 2008 12:33:12 +0000 Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Message-Id: <20080109123311.GP16309@parisc-linux.org> List-Id: References: <4785B7BC.5040106@suse.de> <4785C7D8.2020808@suse.de> In-Reply-To: <4785C7D8.2020808@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Nikanth Karthikesan Cc: grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org On Thu, Jan 10, 2008 at 12:53:04PM +0530, Nikanth Karthikesan wrote: > default: > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > + unlock_kernel(); > return -EINVAL; Surely a bug ... shouldn't this return -ENOTTY? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755225AbYAIMdW (ORCPT ); Wed, 9 Jan 2008 07:33:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752770AbYAIMdO (ORCPT ); Wed, 9 Jan 2008 07:33:14 -0500 Received: from palinux.external.hp.com ([192.25.206.14]:42983 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751424AbYAIMdN (ORCPT ); Wed, 9 Jan 2008 07:33:13 -0500 Date: Wed, 9 Jan 2008 05:33:12 -0700 From: Matthew Wilcox To: Nikanth Karthikesan Cc: grant@torque.net, tim@cyberelk.net, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] Change paride driver to use unlocked_ioctl instead of ioctl Message-ID: <20080109123311.GP16309@parisc-linux.org> References: <4785B7BC.5040106@suse.de> <4785C7D8.2020808@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4785C7D8.2020808@suse.de> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 10, 2008 at 12:53:04PM +0530, Nikanth Karthikesan wrote: > default: > printk("%s: Unimplemented ioctl 0x%x\n", tape->name, cmd); > + unlock_kernel(); > return -EINVAL; Surely a bug ... shouldn't this return -ENOTTY? -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."