From: Andrew Morton <akpm@linux-foundation.org>
To: Steve Hardy <steve@linuxrealtime.co.uk>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
khali@linux-fr.org, "Mark M. Hoffman" <mhoffman@lightlink.com>
Subject: Re: [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI
Date: Thu, 10 Jan 2008 00:30:27 +0000 [thread overview]
Message-ID: <20080109163027.56fbb394.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080104073439.GA22033@toshiba-lt>
On Fri, 4 Jan 2008 07:34:39 +0000
Steve Hardy <steve@linuxrealtime.co.uk> wrote:
> Andrew/Jean,
>
> Sorry for the delay - christmas & getting mutt working delayed my
> revised patch. Here is an updated patch against 2.6.24-rc6, which
> hopefully addresses all comments made so far.
>
> Jean - you mentioned declaring the devices as platform data & writing
> a new-style I2C driver - are there any examples of this approach I can
> refer to? I simply copied what is/was currently in-tree for this
> driver, which seems to work well with the hardware I'm working with (a
> COTS CPCI carrier)
>
> Since I've dropped Thunderbird I hope the patch mangling will be
> fixed.
>
> Any problem, please let me know.
>
The above doesn't constitute a usable changelog. I guess we don't really
need anything in this patch but please do remember that the changelog text
should be included in each new rev of a patch.
>
> Signed-Off by Steve Hardy <steve@linuxrealtime.co.uk>
"Signed-off-by:", please.
Documentation/hwmon/ads7828 | 38 ++++
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1
drivers/hwmon/ads7828.c | 296 ++++++++++++++++++++++++++++++++++
4 files changed, 345 insertions(+)
I assumed that this is to be merged via Mark's git-hwmon tree.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Steve Hardy <steve@linuxrealtime.co.uk>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
khali@linux-fr.org, "Mark M. Hoffman" <mhoffman@lightlink.com>
Subject: Re: [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D
Date: Wed, 9 Jan 2008 16:30:27 -0800 [thread overview]
Message-ID: <20080109163027.56fbb394.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080104073439.GA22033@toshiba-lt>
On Fri, 4 Jan 2008 07:34:39 +0000
Steve Hardy <steve@linuxrealtime.co.uk> wrote:
> Andrew/Jean,
>
> Sorry for the delay - christmas & getting mutt working delayed my
> revised patch. Here is an updated patch against 2.6.24-rc6, which
> hopefully addresses all comments made so far.
>
> Jean - you mentioned declaring the devices as platform data & writing
> a new-style I2C driver - are there any examples of this approach I can
> refer to? I simply copied what is/was currently in-tree for this
> driver, which seems to work well with the hardware I'm working with (a
> COTS CPCI carrier)
>
> Since I've dropped Thunderbird I hope the patch mangling will be
> fixed.
>
> Any problem, please let me know.
>
The above doesn't constitute a usable changelog. I guess we don't really
need anything in this patch but please do remember that the changelog text
should be included in each new rev of a patch.
>
> Signed-Off by Steve Hardy <steve@linuxrealtime.co.uk>
"Signed-off-by:", please.
Documentation/hwmon/ads7828 | 38 ++++
drivers/hwmon/Kconfig | 10 +
drivers/hwmon/Makefile | 1
drivers/hwmon/ads7828.c | 296 ++++++++++++++++++++++++++++++++++
4 files changed, 345 insertions(+)
I assumed that this is to be merged via Mark's git-hwmon tree.
next prev parent reply other threads:[~2008-01-10 0:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <477D50CC.6020504@linuxrealtime.co.uk>
2008-01-04 7:34 ` [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI Steve Hardy
2008-01-04 7:34 ` [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D Steve Hardy
2008-01-10 0:30 ` Andrew Morton [this message]
2008-01-10 0:30 ` Andrew Morton
2008-01-10 13:19 ` [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI Jean Delvare
2008-01-10 13:19 ` [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D Jean Delvare
2008-01-14 22:28 ` [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI Steve Hardy
2008-01-14 22:28 ` [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D Steve Hardy
2008-01-15 10:31 ` [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI Jean Delvare
2008-01-15 10:31 ` [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 A-D Jean Delvare
2007-12-03 17:59 [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI ADS7828 Steve Hardy
2007-12-12 10:25 ` [lm-sensors] [PATCH 1/1] : hwmon - new chip driver for TI Andrew Morton
2007-12-18 20:56 ` Steve Hardy
2007-12-19 14:54 ` Jean Delvare
2007-12-19 15:35 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080109163027.56fbb394.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
--cc=steve@linuxrealtime.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.