From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Daniel P. Berrange" Subject: Re: [PATCH] Dynamic modes support for PV xenfb (0 of 2) Date: Wed, 9 Jan 2008 21:29:18 +0000 Message-ID: <20080109212918.GS8732@redhat.com> References: <47833537.3E48.0018.0@novell.com> <20080109194325.GN8732@redhat.com> <4784D6C5.3E48.0018.0@novell.com> Reply-To: "Daniel P. Berrange" Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <4784D6C5.3E48.0018.0@novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pat Campbell Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Wed, Jan 09, 2008 at 02:16:07PM -0700, Pat Campbell wrote: > >>> On Wed, Jan 9, 2008 at 12:43 PM, in message <20080109194325.GN8732@redhat.com>, > "Daniel P. Berrange" wrote: > > On Tue, Jan 08, 2008 at 08:34:31AM - 0700, Pat Campbell wrote: > >> New xenstore virtual machine specific VNC attributes: > >> vncresizable- pvfb: For those that don't need higher > >> resolutions in their guest. Default: 0. > > > > Is there really any compelling need to make the resize stuff > > a config option ? IMHO it should just always be on by default. > > If a user doesn't want to resize the guest, then they can simply > > not run the xrandr tool in their guest. > > My thinking was that some people would not want the extra > 3MB memory hit caused by the larger frame buffer. If no one > else has any input as to the 5MB size I will remove that option. That's a fair point. HOw about having a 'videoram=XXX' config parameter instead, and have your new resize feature also inform the guest of the desired RAM allocation. Then we can allow any resolution that fits in the configured RAM. A videoram param is something that's a reasonably generic concept across full and paravirt and different hypervisors so would fit into nicely to the UI of management tools Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|