From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JCiYd-0000NA-Ch for user-mode-linux-devel@lists.sourceforge.net; Wed, 09 Jan 2008 13:33:55 -0800 Received: from smtp6.pp.htv.fi ([213.243.153.40]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1JCiYY-0002Vk-Ra for user-mode-linux-devel@lists.sourceforge.net; Wed, 09 Jan 2008 13:33:55 -0800 Date: Wed, 9 Jan 2008 23:33:06 +0200 From: Adrian Bunk Message-ID: <20080109213305.GC4394@does.not.exist> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Subject: Re: [uml-devel] uml and -regparm=3 List-Id: The user-mode Linux development list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: user-mode-linux-devel-bounces@lists.sourceforge.net Errors-To: user-mode-linux-devel-bounces@lists.sourceforge.net To: Miklos Szeredi Cc: user-mode-linux-devel@lists.sourceforge.net, jdike@addtoit.com, linux-kernel@vger.kernel.org, andi@firstfloor.org, akpm@linux-foundation.org, harvey.harrison@gmail.com T24gV2VkLCBKYW4gMDksIDIwMDggYXQgMTA6MjA6NDlQTSArMDEwMCwgTWlrbG9zIFN6ZXJlZGkg d3JvdGU6Cj4gPiBNaWtsb3MgU3plcmVkaSA8bWlrbG9zQHN6ZXJlZGkuaHU+IHdyaXRlczoKPiA+ IAo+ID4gPiBGQVNUQ0FMTCBpcyBkZWZpbmVkIGVtcHR5IGluIC1tbSwgYnV0IFVNTCBpcyBub3Qg Y29tcGlsZWQgd2l0aAo+ID4gPiAtbXJlZ3Bhcm09MyBhbmQgc28gdGhpcyBicmVha3MgdGhpbmdz IChJIG5vdGljZWQgcHJvYmxlbXMgd2l0aAo+ID4gPiByd3NlbV9kb3duX3dyaXRlX2ZhaWxlZCku Cj4gPiA+Cj4gPiA+IFRyaWVkIHJlY29tcGlsaW5nIFVNTCB3aXRoIC1tcmVncGFybT0zLCBidXQg dGhhdCByZXN1bHRlZCBpbiBhIHN0cmFuZ2UKPiA+ID4gZmFpbHVyZSBpbW1lZGlhdGVseSBhZnRl ciBzdGFydHVwOgo+ID4gPgo+ID4gPiB8JUfDr8K/wr0lQDogSW52YWxpZCBhcmd1bWVudAo+ID4g Pgo+ID4gPiBXaGF0J3MgdXA/Cj4gPiAKPiA+IFVNTCBsaW5rcyB3aXRoIGdsaWJjIGFuZCB0aGF0 IGRvZXMgbm90IHVzZSAtbXJlZ3Bhcm0uIAo+ID4gCj4gPiBZb3UgY2FuIG9ubHkgdXNlIC1tcmVn cGFybSBpbiB1c2VyIHNwYWNlIGlmIHlvdSByZWNvbXBpbGUKPiA+IGFsbCBsaWJyYXJpZXMgdG9v Lgo+IAo+IEFoLCByaWdodC4gIEkgZGlkbid0IHRoaW5rIG9mIHRoYXQuCj4gCj4gRG9lcyB0aGF0 IG1lYW4gdGhhdCBGQVNUQ0FMTCByZW1vdmFscyB3aWxsIGhhdmUgdG8gYmUgdW5kb25lPyAgT3Ig aXMKPiB0aGVyZSBhbiBhbHRlcm5hdGl2ZT8KCkl0J3MgZW5vdWdoIHdoZW4gd2Uga2VlcCBmYXN0 Y2FsbC9GQVNUQ0FMTCBpbiB0aGUgZmV3IGNhc2VzIHdoZXJlIFVNTCAKY2FsbHMgYXNzZW1ibGVy IGNvZGUgd2l0aCB0aGlzIGNhbGxpbmcgY29udmVudGlvbi4gWzFdCgo+IE1pa2xvcwoKY3UKQWRy aWFuCgpbMV0gaHR0cDovL2xrbWwub3JnL2xrbWwvMjAwNy8xMi80LzQyNQoKLS0gCgogICAgICAg IklzIHRoZXJlIG5vdCBwcm9taXNlIG9mIHJhaW4/IiBMaW5nIFRhbiBhc2tlZCBzdWRkZW5seSBv dXQKICAgICAgICBvZiB0aGUgZGFya25lc3MuIFRoZXJlIGhhZCBiZWVuIG5lZWQgb2YgcmFpbiBm b3IgbWFueSBkYXlzLgogICAgICAgIk9ubHkgYSBwcm9taXNlLCIgTGFvIEVyIHNhaWQuCiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFBlYXJsIFMuIEJ1Y2sgLSBEcmFnb24g U2VlZAoKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KQ2hlY2sgb3V0IHRoZSBuZXcgU291cmNlRm9yZ2UubmV0 IE1hcmtldHBsYWNlLgpJdCdzIHRoZSBiZXN0IHBsYWNlIHRvIGJ1eSBvciBzZWxsIHNlcnZpY2Vz IGZvcgpqdXN0IGFib3V0IGFueXRoaW5nIE9wZW4gU291cmNlLgpodHRwOi8vYWQuZG91YmxlY2xp Y2submV0L2NsazsxNjQyMTYyMzk7MTM1MDMwMzg7dz9odHRwOi8vc2YubmV0L21hcmtldHBsYWNl Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fClVzZXItbW9k ZS1saW51eC1kZXZlbCBtYWlsaW5nIGxpc3QKVXNlci1tb2RlLWxpbnV4LWRldmVsQGxpc3RzLnNv dXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5m by91c2VyLW1vZGUtbGludXgtZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756184AbYAIVd6 (ORCPT ); Wed, 9 Jan 2008 16:33:58 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753301AbYAIVdu (ORCPT ); Wed, 9 Jan 2008 16:33:50 -0500 Received: from smtp6.pp.htv.fi ([213.243.153.40]:33234 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752360AbYAIVdu (ORCPT ); Wed, 9 Jan 2008 16:33:50 -0500 Date: Wed, 9 Jan 2008 23:33:06 +0200 From: Adrian Bunk To: Miklos Szeredi Cc: andi@firstfloor.org, harvey.harrison@gmail.com, jdike@addtoit.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, user-mode-linux-devel@lists.sourceforge.net Subject: Re: uml and -regparm=3 Message-ID: <20080109213305.GC4394@does.not.exist> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17 (2007-12-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 09, 2008 at 10:20:49PM +0100, Miklos Szeredi wrote: > > Miklos Szeredi writes: > > > > > FASTCALL is defined empty in -mm, but UML is not compiled with > > > -mregparm=3 and so this breaks things (I noticed problems with > > > rwsem_down_write_failed). > > > > > > Tried recompiling UML with -mregparm=3, but that resulted in a strange > > > failure immediately after startup: > > > > > > |%G�%@: Invalid argument > > > > > > What's up? > > > > UML links with glibc and that does not use -mregparm. > > > > You can only use -mregparm in user space if you recompile > > all libraries too. > > Ah, right. I didn't think of that. > > Does that mean that FASTCALL removals will have to be undone? Or is > there an alternative? It's enough when we keep fastcall/FASTCALL in the few cases where UML calls assembler code with this calling convention. [1] > Miklos cu Adrian [1] http://lkml.org/lkml/2007/12/4/425 -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed