All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: jreiser@BitWagon.com, mingo@elte.hu
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: STT_FUNC for assembler checksum and semaphore ops" in git-x86
Date: Wed, 9 Jan 2008 22:57:25 +0100	[thread overview]
Message-ID: <20080109215725.GA18185@basil.nowhere.org> (raw)


In gitx86:

commit 692effca950d7c6032e8e2ae785a32383e7af4a3
Author: John Reiser <jreiser@BitWagon.com>
Date:   Wed Jan 9 13:31:12 2008 +0100

    STT_FUNC for assembler checksum and semaphore ops
...
    Comments?
    
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/arch/x86/lib/checksum_32.S b/arch/x86/lib/checksum_32.S
index adbccd0..1f9aacb 100644
--- a/arch/x86/lib/checksum_32.S
+++ b/arch/x86/lib/checksum_32.S
@@ -48,6 +48,7 @@ unsigned int csum_partial(const unsigned char * buff, int len, unsigned int sum)
           * Fortunately, it is easy to convert 2-byte alignment to 4-byte
           * alignment for the unrolled loop.
           */           
+       .type csum_partial, @function
 ENTRY(csum_partial)
+       .type csum_partial, @function
 ENTRY(csum_partial)
        CFI_STARTPROC
        pushl %esi
@@ -141,11 +142,13 @@ ENTRY(csum_partial)
        ret
        CFI_ENDPROC
 ENDPROC(csum_partial)
+       .size csum_partial, . - csum_partial

AK:
Better option would be to just add to ENTRY/ENDPROC

do something like (untested) 

#define ENTRY(x) \
	...
	.set curfunc, x

#define ENDPROC(x) \
	...
	.size x - curfunc

-Andi

             reply	other threads:[~2008-01-09 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 21:57 Andi Kleen [this message]
2008-01-10  7:42 ` STT_FUNC for assembler checksum and semaphore ops" in git-x86 Sam Ravnborg
2008-01-10 16:37   ` John Reiser
2008-01-10 18:02     ` Andi Kleen
2008-01-11  0:59       ` John Reiser
2008-01-11  2:57         ` Andi Kleen
2008-01-11  4:18           ` John Reiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109215725.GA18185@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=jreiser@BitWagon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.