All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: Matthew Wilcox <matthew@wil.cx>, Jon Watte <jwatte@gmail.com>,
	Andi Kleen <andi@firstfloor.org>,
	James Bottomley <James.Bottomley@HansenPartnership.com>,
	linux-scsi@vger.kernel.org
Subject: Re: AHCI finds disks; no /dev/sd inodes bound?
Date: Wed, 9 Jan 2008 23:23:08 +0100	[thread overview]
Message-ID: <20080109222308.GE15612@one.firstfloor.org> (raw)
In-Reply-To: <47853FA7.9050506@s5r6.in-berlin.de>

On Wed, Jan 09, 2008 at 10:41:59PM +0100, Stefan Richter wrote:
> Matthew Wilcox wrote:
> > OK, how about this?
> > 
> > config BLK_DEV_ATA_SD
> > 	tristate "ATA disc support"
> > 	select BLK_DEV_SD
> > 
> > config BLK_DEV_ATA_SR
> > 	tristate "ATA CDROM support"
> > 	select BLK_DEV_SR
> 
> It's probably OK for many uses.
> 
> However, this further obfuscates the fact that libata uses Linux' SCSI
> midlayer and highlevel.  Which is a bad thing.  For example, there are

People are not interested in how libata is implemented internally.
They just want their SATA interfaces to work.

Kconfig is also not an educational facility or high level
design description of the code, but a pragmatic tool to get the job
done.

> further configuration options in the SCSI menu which influence the SCSI
> midlayer and highlevel, and therefore influence the software stack which
> drives the ATA disks and ATA CD-ROMs.  Hence this change does not make
> the configuration menu more logical.

I think Matthew's patch with appropiate help texts is a good idea.

-Andi

  reply	other threads:[~2008-01-09 22:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  7:40 AHCI finds disks; no /dev/sd inodes bound? Jon Watte
2008-01-09 16:45 ` Andi Kleen
2008-01-09 17:21   ` Jon Watte
2008-01-09 17:29     ` James Bottomley
2008-01-09 17:49       ` Andi Kleen
2008-01-09 18:33         ` Stefan Richter
2008-01-09 18:37           ` Stefan Richter
2008-01-09 18:50           ` Stefan Richter
2008-01-09 20:36           ` Jon Watte
2008-01-09 20:58             ` Matthew Wilcox
2008-01-09 21:41               ` Stefan Richter
2008-01-09 22:23                 ` Andi Kleen [this message]
2008-01-09 23:03                   ` Stefan Richter
2008-01-09 23:16                     ` Stefan Richter
2008-01-10  0:38                     ` Andi Kleen
2008-01-10  0:53                       ` Stefan Richter
2008-01-10  4:47               ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080109222308.GE15612@one.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=jwatte@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.