From: David Gibson <david@gibson.dropbear.id.au>
To: Scott Wood <scottwood@freescale.com>
Cc: linuxppc-dev@ozlabs.org, jdl@jdl.com
Subject: Re: [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file.
Date: Thu, 10 Jan 2008 16:09:58 +1100 [thread overview]
Message-ID: <20080110050958.GD19088@localhost.localdomain> (raw)
In-Reply-To: <20080106224623.GA8239@ld0162-tx32.am.freescale.net>
On Sun, Jan 06, 2008 at 04:46:24PM -0600, Scott Wood wrote:
> On Sun, Jan 06, 2008 at 02:37:16PM +1100, David Gibson wrote:
> > > out:
> > > + free((void *)file->dir);
> >
> > That cast shouldn't be there.
>
> It generates a constness warning otherwise. I was on the fence over
> whether to just remove the constness (even though the data is never
> modified during its lifetime); would that be preferable?
I think that is preferable.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-01-10 5:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 21:10 [PATCH 2/3] Handle absolute pathnames correctly in dtc_open_file Scott Wood
2008-01-06 3:37 ` David Gibson
2008-01-06 22:46 ` Scott Wood
2008-01-07 15:25 ` Jon Loeliger
2008-01-10 5:09 ` David Gibson [this message]
2008-01-07 15:22 ` Jon Loeliger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110050958.GD19088@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.