All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>,
	Ian Pratt <Ian.Pratt@eu.citrix.com>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: RE: "cpus" config parameter broken?
Date: Thu, 10 Jan 2008 15:53:21 -0700	[thread overview]
Message-ID: <20080110155321125.00000003216@djm-pc> (raw)
In-Reply-To: <C3AC50D2.1203A%Keir.Fraser@cl.cam.ac.uk>

> > So modulo-izing the cpus parameter code will eliminate this
> > case, but I still wonder if vcpu_set_affinity should reject any
> > mask that has bits set beyond max_pcpu instead of silently
> > ignoring those bits.  Seems like an accident waiting to happen
> > and indeed I got bitten by it.
> >
> > Which is why I proposed tightening the definition of all affinity
> > masks (and strings representing masks) to "if you try to enable
> > a bit in the cpumask that refers to a non-existent processor, you
> > will get an error"
> 
> That doesn't play nicely with CPU hotplug (not supported yet, 
> but could well
> be in future) where the online_map could be continually 
> changing. The model
> I'm aiming for in Xen is to remember all the CPUs requested by the
> toolstack, but only schedule onto the subset that are 
> actually online right
> now (obviously). The implementation of this is of course 
> quite simple given
> the CPU hotplug is not supported right now.

Agreed, but even with CPU hotplug there will be some max_pcpu value
on any given machine.  That's why I said "non-existent processor"
in the proposal even though you said "offline processor".

Dan

  reply	other threads:[~2008-01-10 22:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  1:09 "cpus" config parameter broken? Dan Magenheimer
2008-01-08  1:57 ` Ian Pratt
2008-01-09 18:40   ` Dan Magenheimer
2008-01-09 19:17     ` Keir Fraser
2008-01-10 18:38       ` Dan Magenheimer
2008-01-10 20:50         ` Keir Fraser
2008-01-10 21:10           ` Dan Magenheimer
2008-01-10 21:57             ` Keir Fraser
2008-01-10 22:40               ` Dan Magenheimer
2008-01-10 22:46                 ` Keir Fraser
2008-01-10 22:53                   ` Dan Magenheimer [this message]
2008-01-10 22:55                     ` Keir Fraser
2008-01-10 23:46                       ` Dan Magenheimer
2008-01-10 23:53                         ` Keir Fraser
2008-01-11  0:43                           ` Dan Magenheimer
2008-01-11  0:53                             ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080110155321125.00000003216@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=Ian.Pratt@eu.citrix.com \
    --cc=Keir.Fraser@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.