From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
akpm@linux-foundation.org, mingo@elte.hu, ak@suse.de
Subject: Re: [PATCH 1/7] Add tests/ directory
Date: Thu, 10 Jan 2008 21:24:20 +0530 [thread overview]
Message-ID: <20080110155420.GA8138@in.ibm.com> (raw)
In-Reply-To: <20080110151635.GA15361@uranus.ravnborg.org>
On Thu, Jan 10, 2008 at 04:16:35PM +0100, Sam Ravnborg wrote:
> On Thu, Jan 10, 2008 at 05:25:37PM +0530, Ananth N Mavinakayanahalli wrote:
> > From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> >
> > Create a toplevel tests/ directory to house in-kernel subsystem specific
> > tests.
> >
> > PS: I am not sure if I've gotten the Makefile change right.
> >
> > Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
> > ---
> > Makefile | 3 +++
> > lib/Kconfig.debug | 2 ++
> > tests/Kconfig | 11 +++++++++++
> > tests/Makefile | 3 +++
> > 4 files changed, 19 insertions(+)
> >
> > Index: linux-2.6.24-rc6/lib/Kconfig.debug
> > ===================================================================
> > --- linux-2.6.24-rc6.orig/lib/Kconfig.debug
> > +++ linux-2.6.24-rc6/lib/Kconfig.debug
> > @@ -596,3 +596,5 @@ config PROVIDE_OHCI1394_DMA_INIT
> > See Documentation/debugging-via-ohci1394.txt for more information.
> >
> > source "samples/Kconfig"
> > +
> > +source "tests/Kconfig"
> > Index: linux-2.6.24-rc6/tests/Kconfig
> > ===================================================================
> > --- /dev/null
> > +++ linux-2.6.24-rc6/tests/Kconfig
> > @@ -0,0 +1,11 @@
> > +# tests/Kconfig
> > +
> > +menuconfig KERNEL_TESTS
> > + bool "Kernel subsystem tests"
> > + help
> > + You can build kernel subsystem specific tests.
> > +
> > +if KERNEL_TESTS
> > +
> > +endif # KERNEL_TESTS
> > +
> > Index: linux-2.6.24-rc6/tests/Makefile
> > ===================================================================
> > --- /dev/null
> > +++ linux-2.6.24-rc6/tests/Makefile
> > @@ -0,0 +1,3 @@
> > +#
> > +# Makefile for kernel subsystem specific tests
> > +#
> > Index: linux-2.6.24-rc6/Makefile
> > ===================================================================
> > --- linux-2.6.24-rc6.orig/Makefile
> > +++ linux-2.6.24-rc6/Makefile
> > @@ -598,6 +598,9 @@ export mod_strip_cmd
> >
> > ifeq ($(KBUILD_EXTMOD),)
> > core-y += kernel/ mm/ fs/ ipc/ security/ crypto/ block/
> > +ifdef CONFIG_KERNEL_TESTS
> > +core-y += tests/
> > +endif
>
> CONFIG_KERNEL_TESTS is a bool so this should be written as:
> core-$(CONFIG_KERNEL_TESTS) += tests/
>
> With this change:
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Thanks Sam!
Updated patch below...
From: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Create a toplevel tests/ directory to house in-kernel subsystem specific
tests.
PS: I am not sure if I've gotten the Makefile change right.
Signed-off-by: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
Acked-by: Sam Ravnborg <sam@ravnborg.org>
---
Makefile | 1 +
lib/Kconfig.debug | 2 ++
tests/Kconfig | 11 +++++++++++
tests/Makefile | 3 +++
4 files changed, 17 insertions(+)
Index: linux-2.6.24-rc6/lib/Kconfig.debug
===================================================================
--- linux-2.6.24-rc6.orig/lib/Kconfig.debug
+++ linux-2.6.24-rc6/lib/Kconfig.debug
@@ -596,3 +596,5 @@ config PROVIDE_OHCI1394_DMA_INIT
See Documentation/debugging-via-ohci1394.txt for more information.
source "samples/Kconfig"
+
+source "tests/Kconfig"
Index: linux-2.6.24-rc6/tests/Kconfig
===================================================================
--- /dev/null
+++ linux-2.6.24-rc6/tests/Kconfig
@@ -0,0 +1,11 @@
+# tests/Kconfig
+
+menuconfig KERNEL_TESTS
+ bool "Kernel subsystem tests"
+ help
+ You can build kernel subsystem specific tests.
+
+if KERNEL_TESTS
+
+endif # KERNEL_TESTS
+
Index: linux-2.6.24-rc6/tests/Makefile
===================================================================
--- /dev/null
+++ linux-2.6.24-rc6/tests/Makefile
@@ -0,0 +1,3 @@
+#
+# Makefile for kernel subsystem specific tests
+#
Index: linux-2.6.24-rc6/Makefile
===================================================================
--- linux-2.6.24-rc6.orig/Makefile
+++ linux-2.6.24-rc6/Makefile
@@ -598,6 +598,7 @@ export mod_strip_cmd
ifeq ($(KBUILD_EXTMOD),)
core-y += kernel/ mm/ fs/ ipc/ security/ crypto/ block/
+core-$(CONFIG_KERNEL_TESTS) += tests/
vmlinux-dirs := $(patsubst %/,%,$(filter %/, $(init-y) $(init-m) \
$(core-y) $(core-m) $(drivers-y) $(drivers-m) \
next prev parent reply other threads:[~2008-01-10 15:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-10 11:54 [PATCH 0/7] Create and populate toplevel tests/ directory Ananth N Mavinakayanahalli
2008-01-10 11:55 ` [PATCH 1/7] Add " Ananth N Mavinakayanahalli
2008-01-10 15:16 ` Sam Ravnborg
2008-01-10 15:54 ` Ananth N Mavinakayanahalli [this message]
2008-01-10 11:56 ` [PATCH 2/7] Move locking-selftest to tests/ Ananth N Mavinakayanahalli
2008-01-10 11:57 ` [PATCH 3/7] Move rcutorture " Ananth N Mavinakayanahalli
2008-01-10 23:14 ` Josh Triplett
2008-01-14 7:01 ` Paul E. McKenney
2008-01-10 11:58 ` [PATCH 4/7] Move rtmutex tests under tests/ Ananth N Mavinakayanahalli
2008-01-10 11:59 ` [PATCH 5/7] Move synchro-test " Ananth N Mavinakayanahalli
2008-01-10 12:00 ` [PATCH 6/7] Move lkdtm " Ananth N Mavinakayanahalli
2008-01-10 12:01 ` [PATCH 7/7] Add kprobes smoke tests " Ananth N Mavinakayanahalli
2008-01-10 15:17 ` [PATCH 0/7] Create and populate toplevel tests/ directory Sam Ravnborg
2008-01-14 22:55 ` Matt Mackall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080110155420.GA8138@in.ibm.com \
--to=ananth@in.ibm.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.