All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: David Miller <davem@davemloft.net>
Cc: hpa@zytor.com, netdev@vger.kernel.org, klibc@zytor.com
Subject: Re: [klibc] [patch] import socket defines
Date: Fri, 11 Jan 2008 01:23:37 -0500	[thread overview]
Message-ID: <200801110123.38406.vapier@gentoo.org> (raw)
In-Reply-To: <20080110.221615.188955433.davem@davemloft.net>

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

On Friday 11 January 2008, David Miller wrote:
> From: "H. Peter Anvin" <hpa@zytor.com>
> > Seems the most logical thing to do would be to break out the small
> > portion that everyone wants into <linux/sockaddr.h> or somesuch, and
> > then remove those ifdefs entirely.
> >
> > Proposed patch (still being tested) attached...
>
> I think this would clearly break existing glibc builds.
>
> I agree with fixing the ifdef checks, but not like this.

how ?  the large crap in linux/socket.h never made it into glibc builds, and 
the few things at the top which were relocated to linux/sockaddr.h are still 
pulled in via linux/socket.h.  for glibc, the resulting '#include 
<linux/socket.h>' should be unchanged.
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 835 bytes --]

  reply	other threads:[~2008-01-11  6:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200801012029.21432.vapier@gentoo.org>
     [not found] ` <477AF86E.1080309@zytor.com>
     [not found]   ` <200801020830.43449.vapier@gentoo.org>
2008-01-02 18:09     ` [klibc] [patch] import socket defines H. Peter Anvin
2008-01-11  6:16       ` David Miller
2008-01-11  6:23         ` Mike Frysinger [this message]
2008-01-11  6:41           ` H. Peter Anvin
2008-01-11  6:47           ` David Miller
2008-01-11  7:02             ` H. Peter Anvin
2008-01-11  7:07             ` Mike Frysinger
2008-01-11  7:10               ` H. Peter Anvin
2008-01-11  7:42                 ` H. Peter Anvin
2008-01-11  7:57                 ` Mike Frysinger
2008-01-11  8:00                   ` H. Peter Anvin
2008-01-11  9:02                     ` Mike Frysinger
2008-01-11  9:28                       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801110123.38406.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=davem@davemloft.net \
    --cc=hpa@zytor.com \
    --cc=klibc@zytor.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.