From: Jens Axboe <jens.axboe@oracle.com>
To: Chris Smowton <cs448@cam.ac.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Splice(): exports for module programmers
Date: Fri, 11 Jan 2008 10:06:21 +0100 [thread overview]
Message-ID: <20080111090621.GH6258@kernel.dk> (raw)
In-Reply-To: <4786D7E5.2080701@cam.ac.uk>
On Fri, Jan 11 2008, Chris Smowton wrote:
> Just a couple of quick questions if anyone can shed light regarding
> functions exported for modules relating to splice():
>
> * Is there a particular reason why the useful helper __splice_from_pipe
> is exported, but not the locking equivalent splice_from_pipe or its
> equally useful helper splice_to_pipe?
> * Similarly is there anything wrong with exporting the generic
> pipe-buffer operations (e.g. generic_pipe_buf_map) to save effort
> writing modules which implement splice_read and splice_write?
>
> Are these unexported because they are unstable and not yet considered
> suitable for use, or simply because nobody's written a module that
> splice()s yet?
The latter, I generally don't export things until they are used.
__splice_from_pipe() wasn't exported until some file systems grew they
own splice implementations.
--
Jens Axboe
prev parent reply other threads:[~2008-01-11 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 2:43 Splice(): exports for module programmers Chris Smowton
2008-01-11 9:06 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080111090621.GH6258@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=cs448@cam.ac.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.