diff for duplicates of <20080111093211.GC8143@elte.hu> diff --git a/a/1.txt b/N1/1.txt index 5df4b4a..59366b7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -66,12 +66,12 @@ clearing the cpu_idle_state and disabling interrupts (hence the RFC). --------- --------- cpu_idle_wait(): cpu_idle(): | __cpu_cpu_var(is_idle) = 1; - | if (__get_cpu_var(cpu_idle_state)) /* = 0 */ + | if (__get_cpu_var(cpu_idle_state)) /* == 0 */ per_cpu(cpu_idle_state, 1) = 1; | - if (per_cpu(is_idle, 1)) /* = 1 */ | + if (per_cpu(is_idle, 1)) /* == 1 */ | smp_call_function(1) | | receives ipi and runs do_nothing. - wait on map = empty idle(); + wait on map == empty idle(); /* waits forever */ So really we need interrupts off for most of this then. One might think @@ -118,7 +118,8 @@ Signed-off-by: Ingo Molnar <mingo@elte.hu> 2 files changed, 22 insertions(+) Index: linux-x86.q/arch/x86/kernel/process_32.c -=================================--- linux-x86.q.orig/arch/x86/kernel/process_32.c +=================================================================== +--- linux-x86.q.orig/arch/x86/kernel/process_32.c +++ linux-x86.q/arch/x86/kernel/process_32.c @@ -214,6 +214,10 @@ void cpu_idle(void) } @@ -146,7 +147,8 @@ Index: linux-x86.q/arch/x86/kernel/process_32.c set_cpus_allowed(current, tmp); Index: linux-x86.q/arch/x86/kernel/process_64.c -=================================--- linux-x86.q.orig/arch/x86/kernel/process_64.c +=================================================================== +--- linux-x86.q.orig/arch/x86/kernel/process_64.c +++ linux-x86.q/arch/x86/kernel/process_64.c @@ -204,6 +204,10 @@ void cpu_idle(void) } diff --git a/a/content_digest b/N1/content_digest index ccd25fd..4cb8cd8 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -6,7 +6,7 @@ "ref\0478736C6.3080802@suspend2.net\0" "From\0Ingo Molnar <mingo@elte.hu>\0" "Subject\0Re: CONFIG_NO_HZ breaks blktrace timestamps\0" - "Date\0Fri, 11 Jan 2008 09:32:11 +0000\0" + "Date\0Fri, 11 Jan 2008 10:32:11 +0100\0" "To\0nigel@nigel.suspend2.net\0" "Cc\0Jens Axboe <jens.axboe@oracle.com>" David Dillow <dillowda@ornl.gov> @@ -85,12 +85,12 @@ " --------- ---------\n" " cpu_idle_wait(): cpu_idle():\n" " | __cpu_cpu_var(is_idle) = 1;\n" - " | if (__get_cpu_var(cpu_idle_state)) /* = 0 */\n" + " | if (__get_cpu_var(cpu_idle_state)) /* == 0 */\n" " per_cpu(cpu_idle_state, 1) = 1; |\n" - " if (per_cpu(is_idle, 1)) /* = 1 */ |\n" + " if (per_cpu(is_idle, 1)) /* == 1 */ |\n" " smp_call_function(1) |\n" " | receives ipi and runs do_nothing.\n" - " wait on map = empty idle();\n" + " wait on map == empty idle();\n" " /* waits forever */\n" "\n" "So really we need interrupts off for most of this then. One might think\n" @@ -137,7 +137,8 @@ " 2 files changed, 22 insertions(+)\n" "\n" "Index: linux-x86.q/arch/x86/kernel/process_32.c\n" - "=================================--- linux-x86.q.orig/arch/x86/kernel/process_32.c\n" + "===================================================================\n" + "--- linux-x86.q.orig/arch/x86/kernel/process_32.c\n" "+++ linux-x86.q/arch/x86/kernel/process_32.c\n" "@@ -214,6 +214,10 @@ void cpu_idle(void)\n" " \t}\n" @@ -165,7 +166,8 @@ " \n" " \tset_cpus_allowed(current, tmp);\n" "Index: linux-x86.q/arch/x86/kernel/process_64.c\n" - "=================================--- linux-x86.q.orig/arch/x86/kernel/process_64.c\n" + "===================================================================\n" + "--- linux-x86.q.orig/arch/x86/kernel/process_64.c\n" "+++ linux-x86.q/arch/x86/kernel/process_64.c\n" "@@ -204,6 +204,10 @@ void cpu_idle(void)\n" " \t}\n" @@ -193,4 +195,4 @@ " \n" " \tset_cpus_allowed(current, tmp);" -2f38911e24858eb6313a3dc9b3e15d6e43b5963af8e43bc41ee404f31ff5795e +5308e18c779a45c2e6a437f66bbec3499d079ed2c8c21ae78f959287f19fc7db
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.