Re: [PATCH 06/12] rt2x00: Put 802.11 data on 4 byte boundary

[Ivo van Doorn <ivdoorn@gmail.com>]

Hi,

> Sorry I'm late in noticing this :\
> 
> > +		/*
> > +		 * The data behind the ieee80211 header must be
> > +		 * aligned on a 4 byte boundary.
> > +		 */
> > +		align = NET_IP_ALIGN + (2 * (header_size % 4 == 0));
> 
> I don't think you should be using NET_IP_ALIGN at all, I think the code
> should be just
> 
> 		align = header_size % 4;
> 
> (which will evaluate to two or four).

Makes sense. I'll fix this asap.

> I have, so far, in mac80211 forced you to align the 802.11 data payload
> to a four-byte boundary *even on powerpc* which is the only platform
> where NET_IP_ALIGN is not two (it is zero because DMA sucks when done to
> unaligned addresses on some powerpc machines).

Ouch, that would make rt2x00usb panicking as soon as it is used when
NET_IP_ALIGN in 0 and alignment is needed. :S
This will be fixed asap as well.

Thanks,

Ivo