From: Andrew Morton <akpm@linux-foundation.org>
To: Krzysztof Helt <krzysztof.h1@poczta.fm>
Cc: hmallat@cc.hut.fi, samr <sam@ravnborg.org>,
Randy Dunlap <rdunlap@xenotime.net>,
linux-fbdev-devel@lists.sourceforge.net, adaplas@gmail.com
Subject: Re: [PATCH] tdfxfb: fix section mismatch warnings
Date: Sat, 12 Jan 2008 03:54:42 -0800 [thread overview]
Message-ID: <20080112035442.667d39ce.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080112052257.afe963fe.krzysztof.h1@poczta.fm>
On Sat, 12 Jan 2008 05:22:57 +0100 Krzysztof Helt <krzysztof.h1@poczta.fm> wrote:
> On Fri, 11 Jan 2008 17:03:53 -0800
> Randy Dunlap <rdunlap@xenotime.net> wrote:
>
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> >
> > tdfxfb_setup() can be __devinit. This fixes the modpost section mismatch
> > warnings:
> >
> >
> > #ifndef MODULE
> > -static void tdfxfb_setup(char *options)
> > +static void __devinit tdfxfb_setup(char *options)
> > {
> > char *this_opt;
>
> It should be rather in the __init section, as it is called only
> from the function below:
>
> static int __init tdfxfb_init(void)
>
yup.
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
prev parent reply other threads:[~2008-01-12 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 1:03 [PATCH] tdfxfb: fix section mismatch warnings Randy Dunlap
2008-01-12 4:22 ` Krzysztof Helt
2008-01-12 11:54 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080112035442.667d39ce.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@gmail.com \
--cc=hmallat@cc.hut.fi \
--cc=krzysztof.h1@poczta.fm \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.