From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers
Date: Sat, 12 Jan 2008 21:19:16 +0100 [thread overview]
Message-ID: <200801122119.16517.bzolnier@gmail.com> (raw)
In-Reply-To: <1200052699-28420-21-git-send-email-bbpetkov@yahoo.de>
On Friday 11 January 2008, Borislav Petkov wrote:
> We merge idefloppy_{input,output}_buffers() into idefloppy_io_buffers() by
> introducing a 4th arg. called direction. According to its value
> we atapi_input_bytes() or atapi_output_bytes(). Also, simplify the interrupt
This change is fine but ...
> handler by removing multiple calls testing the data direction and using a local
> variable instead.
... the patch replaces 'test_bit(PC_WRITING, &pc->flags)' check with
'rq_data_dir(rq) == WRITE' one. While this may look as "trivial" change it
is not such. It should be done only after auditing the driver and making
sure that we are not introducing subtle regressions (=> I see that some
commands are setting PC_WRITING but are not setting REQ_RW bit), especially
given that these changes were not tested with the real hardware.
Please separate this change to another (post-)patch.
PS It would also be nice to remove IDEFLOPPY_DEBUG_BUGS define in a pre-patch.
next prev parent reply other threads:[~2008-01-12 20:20 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-11 11:57 [PATCH 00/21] ide-floppy redux v2 Borislav Petkov
2008-01-11 11:57 ` Borislav Petkov
2008-01-11 11:57 ` [PATCH 01/21] ide-floppy: convert to generic packet commands Borislav Petkov
2008-01-11 11:57 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 02/21] ide-floppy: replace ntoh{s,l} and hton{s,l} calls with the generic byteorder Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 03/21] ide-floppy: remove unnecessary ->handler != NULL check Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 04/21] ide-floppy: cleanup and unify debugging macro calls Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 05/21] ide-floppy: remove struct idefloppy_capabilities_page Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 07/21] ide-floppy: remove struct idefloppy_capacity_descriptor Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 08/21] ide-floppy: remove struct idefloppy_inquiry_result Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 09/21] ide-floppy: remove struct idefloppy_request_sense_result Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 10/21] ide-floppy: remove struct idefloppy_mode_parameter_header Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 11/21] ide-floppy: fix comments formatting Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
[not found] ` <1200052699-28420-14-git-send-email-bbpetkov@yahoo.de>
2008-01-11 11:58 ` [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 15/21] ide-floppy: disambiguate function names Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
[not found] ` <1200052699-28420-17-git-send-email-bbpetkov@yahoo.de>
[not found] ` <1200052699-28420-18-git-send-email-bbpetkov@yahoo.de>
2008-01-11 11:58 ` [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe() Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 20/21] ide-floppy: merge idefloppy_{input,output}_buffers Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-11 11:58 ` [PATCH 21/21] ide-floppy: remove atomic test_*bit macros Borislav Petkov
2008-01-11 11:58 ` Borislav Petkov
2008-01-12 20:19 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:19 ` Bartlomiej Zolnierkiewicz [this message]
2008-01-12 20:18 ` [PATCH 19/21] ide-floppy: fix most of the remaining checkpatch.pl issues Bartlomiej Zolnierkiewicz
2008-01-12 20:18 ` [PATCH 18/21] ide-floppy: fix error handling in idefloppy_probe() Bartlomiej Zolnierkiewicz
2008-01-12 21:12 ` Borislav Petkov
2008-01-12 20:16 ` [PATCH 14/21] ide-floppy: mv idefloppy_{should_,}report_error Bartlomiej Zolnierkiewicz
2008-01-12 20:16 ` [PATCH 12/21] ide-floppy: factor out ioctl handlers from idefloppy_ioctl() Bartlomiej Zolnierkiewicz
2008-01-12 20:16 ` [PATCH 11/21] ide-floppy: fix comments formatting Bartlomiej Zolnierkiewicz
2008-01-12 0:59 ` [PATCH 07/21] ide-floppy: remove struct idefloppy_capacity_descriptor Bartlomiej Zolnierkiewicz
2008-01-12 0:58 ` [PATCH 06/21] ide-floppy: remove struct idefloppy_flexible_disk_page Bartlomiej Zolnierkiewicz
2008-01-12 20:15 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:38 ` Borislav Petkov
2008-01-12 21:32 ` Bartlomiej Zolnierkiewicz
2008-01-11 23:56 ` [PATCH 04/21] ide-floppy: cleanup and unify debugging macro calls Bartlomiej Zolnierkiewicz
2008-01-12 13:46 ` [PATCH 00/21] ide-floppy redux v2 Bartlomiej Zolnierkiewicz
2008-01-12 20:14 ` Bartlomiej Zolnierkiewicz
2008-01-12 20:51 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801122119.16517.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=bbpetkov@yahoo.de \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.