From: Len Brown <lenb@kernel.org>
To: Mattia Dongili <malattia@linux.it>
Cc: linux-acpi@vger.kernel.org
Subject: Re: [PATCH 3/6] sony-laptop: refactor model types
Date: Sun, 13 Jan 2008 02:17:40 -0500 [thread overview]
Message-ID: <200801130217.40492.lenb@kernel.org> (raw)
In-Reply-To: <1200198212-10526-4-git-send-email-malattia@linux.it>
$ scripts/checkpatch.pl ~/Documents/sony3.patch
ERROR: "foo * bar" should be "foo *bar"
#66: FILE: drivers/misc/sony-laptop.c:1200:
+ struct sonypi_event * events;
WARNING: line over 80 characters
#253: FILE: drivers/misc/sony-laptop.c:2380:
+ data_mask = inb_p(dev->cur_ioport->io1.minimum + dev->control->evport_offset);
WARNING: line over 80 characters
#257: FILE: drivers/misc/sony-laptop.c:2383:
+ ev, data_mask, dev->cur_ioport->io1.minimum, dev->control->evport_offset);
WARNING: line over 80 characters
#284: FILE: drivers/misc/sony-laptop.c:2400:
+ dev->control->event_types[i].events[j].event;
ERROR: use tabs not spaces
#289: FILE: drivers/misc/sony-laptop.c:2405:
+ ^Idprintk("unknown event ([%.2x] [%.2x]) at port 0x%.4x(+0x%.2x)\n",$
WARNING: line over 80 characters
#290: FILE: drivers/misc/sony-laptop.c:2406:
+ ev, data_mask, dev->cur_ioport->io1.minimum, dev->control->evport_offset);
ERROR: use tabs not spaces
#290: FILE: drivers/misc/sony-laptop.c:2406:
+ ^I^I^Iev, data_mask, dev->cur_ioport->io1.minimum, dev->control->evport_offset);$
ERROR: use tabs not spaces
#296: FILE: drivers/misc/sony-laptop.c:2411:
+ ^Iacpi_bus_generate_proc_event(dev->acpi_dev, 1, device_event);$
total: 4 errors, 4 warnings, 261 lines checked
next prev parent reply other threads:[~2008-01-13 7:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 4:23 [PATCH 0/6 try2] sony-laptop for 2.6.25 Mattia Dongili
2008-01-13 4:23 ` [PATCH 1/6] sony-laptop: printk more info in sony_pic_call[123] Mattia Dongili
2008-01-13 4:23 ` [PATCH 2/6] sony-laptop: Add Vaio N series to the special init sequence to enable Fn keys Mattia Dongili
2008-01-13 4:23 ` [PATCH 3/6] sony-laptop: refactor model types Mattia Dongili
2008-01-13 4:23 ` [PATCH 4/6] sony-laptop: bump version to 0.6 Mattia Dongili
2008-01-13 4:23 ` [PATCH 5/6] sony-laptop: add Type4 model Mattia Dongili
2008-01-13 4:23 ` [PATCH 6/6] sony-laptop: fix scancode decode Mattia Dongili
2008-01-13 7:17 ` Len Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-01-14 9:05 [PATCH 0/6 try3] sony-laptop for 2.6.25 Mattia Dongili
2008-01-14 9:05 ` [PATCH 1/6] sony-laptop: printk more info in sony_pic_call[123] Mattia Dongili
2008-01-14 9:05 ` [PATCH 2/6] sony-laptop: Add Vaio N series to the special init sequence to enable Fn keys Mattia Dongili
2008-01-14 9:05 ` [PATCH 3/6] sony-laptop: refactor model types Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801130217.40492.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=malattia@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.