From: Andi Kleen <ak@suse.de>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl
Date: Mon, 14 Jan 2008 00:08:37 +0100 [thread overview]
Message-ID: <200801140008.38188.ak@suse.de> (raw)
In-Reply-To: <20080113203223.GA6723@cvg>
On Sunday 13 January 2008 21:32:23 Cyrill Gorcunov wrote:
> This patch converts ioctl call to unlocked_ioctl form with
> explicit big-kernel-lock.
> Also it makes a bit of cleanup
> converting miscdevice structure initialization to C99 form.
First please always send cleanup patches separately. I think you have more
than just the C99 conversion.
Were you even able to compile it? Since ip27 is ia64 only that would need
an IA64 cross compiler or a native ia64 machine.
It's probably better to focus on drivers only that actually build
on x86 :- see http://www.halobates.de/allyes for a compile log
showing all buildable files for x86-64 and i386.
Other than that the patch looks ok to me, but I haven't tried to
compile it either.
-Andi
prev parent reply other threads:[~2008-01-13 23:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-13 20:32 [PATCH] driver: ip27-rtc - convert ioctl to unlocked_ioctl Cyrill Gorcunov
2008-01-13 21:07 ` Alexey Dobriyan
2008-01-13 21:25 ` Cyrill Gorcunov
2008-01-13 21:22 ` Jiri Slaby
2008-01-13 21:29 ` Jiri Slaby
2008-01-13 21:32 ` Cyrill Gorcunov
2008-01-14 6:38 ` Cyrill Gorcunov
2008-01-14 15:14 ` Jiri Slaby
2008-01-14 15:38 ` Cyrill Gorcunov
2008-01-14 15:59 ` Jiri Slaby
2008-01-14 16:07 ` Cyrill Gorcunov
2008-01-14 16:27 ` Jiri Slaby
2008-01-14 16:28 ` Cyrill Gorcunov
2008-01-13 23:08 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801140008.38188.ak@suse.de \
--to=ak@suse.de \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=p_gortmaker@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.