All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Chris Wright <chrisw@sous-sol.org>
Cc: Kevin Winchester <kjwinchester@gmail.com>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"mboton@gmail.com" <mboton@gmail.com>,
	Zach Brown <zach.brown@oracle.com>
Subject: Re: [PATCH] x86: fix ioport unification on 32-bit [was: Re: hwclock failure in x86.git]
Date: Mon, 14 Jan 2008 09:27:25 +0100	[thread overview]
Message-ID: <20080114082725.GD18296@elte.hu> (raw)
In-Reply-To: <20080112010443.GA5476@sequoia.sous-sol.org>


* Chris Wright <chrisw@sous-sol.org> wrote:

> * Ingo Molnar (mingo@elte.hu) wrote:
> > thanks for tracking it down. I pulled that commit for now. But it would 
> > be nice to figure out what's going on there.
> 
> Zach was right. The unification was broken for 32-bit; it was missing 
> the actual pushf/popf EFLAGS manipluation (set_iopl_mask()) and 
> would've broken task switching between processes w/ different iopl in 
> paravirt guests too.  64-bit sys_iopl just does pt_regs->flags 
> modification and lets syscall/sysret plus ptregscall sync and do 
> EFLAGS update.
> 
> Also, use of volatile looks like leftover cruft.
> 
> This patch in on top of Miguel's (can respin to standalone if that's 
> better). [...]

thanks, applied.

	Ingo

  parent reply	other threads:[~2008-01-14  8:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-10 23:28 hwclock failure in x86.git Kevin Winchester
2008-01-10 23:32 ` H. Peter Anvin
2008-01-10 23:50   ` Kevin Winchester
2008-01-11  1:13     ` H. Peter Anvin
2008-01-11  2:04       ` Kevin Winchester
2008-01-11 14:03         ` Ingo Molnar
2008-01-11 23:58           ` Miguel Botón
2008-01-12  1:04           ` [PATCH] x86: fix ioport unification on 32-bit [was: Re: hwclock failure in x86.git] Chris Wright
2008-01-12  1:06             ` [PATCH] x86: refactor ioport unification Chris Wright
2008-01-14  8:32               ` Ingo Molnar
2008-01-14  8:27             ` Ingo Molnar [this message]
2008-01-11  2:27       ` hwclock failure in x86.git Kevin Winchester
2008-01-11  2:55         ` Zach Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080114082725.GD18296@elte.hu \
    --to=mingo@elte.hu \
    --cc=chrisw@sous-sol.org \
    --cc=hpa@zytor.com \
    --cc=kjwinchester@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mboton@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.